DO NO SUMMIT: bluetooth: Use a LevelListDrawable instead of an array of drawables

chrome/android/java/src/org/chromium/chrome/browser/ItemChooserDialog.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser;
 
 import android.app.Activity;
 import android.app.Dialog;
 import android.content.Context;
 import android.content.DialogInterface;
@@ skipping 336 matching lines @@
 
             // If there is at least one item with an icon then we set mImageView's
             // visibility to INVISIBLE for all items with no icons. We do this
             // so that all items' desriptions are aligned.
             if (!mHasIcon) {
                 row.mImageView.setVisibility(View.GONE);
             } else {
                 ItemChooserRow item = getItem(position);
                 if (item.mIcon != null) {
                     row.mImageView.setContentDescription(item.mIconDescription);
+
+                    // Save the icon's level since setImageLevel could
+                    // replace the drawable's level.
+                    int drawableLevel = item.mIcon.getLevel();

[ortuno, 2017/04/18 06:57:07]

This seems pretty leaky.

[David Trainor- moved to gerrit, 2017/04/19 21:32:07]

Should mIconLevel or "mSignalLevel" or something be a top level item concept? 
That way if it changes you just know to refresh and can always push here instead
of pulling the level first?

[ortuno, 2017/04/19 23:48:02]

Oh right, we can save it as part of ItemChooserRow and then set it here. Done.

+
                     row.mImageView.setImageDrawable(item.mIcon);
+
+                    row.mImageView.setImageLevel(drawableLevel);
                     row.mImageView.setVisibility(View.VISIBLE);
                 } else {
                     row.mImageView.setVisibility(View.INVISIBLE);
                     row.mImageView.setImageDrawable(null);
                     row.mImageView.setContentDescription(null);
                 }
                 row.mImageView.setSelected(position == mSelectedItem);
             }
             return convertView;
         }
@@ skipping 313 matching lines @@
     }
 
     /**
      * Returns the ItemAdapter associated with this class. For use with tests only.
      */
     @VisibleForTesting
     public ItemAdapter getItemAdapterForTesting() {
         return mItemAdapter;
     }
 }