Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issue 2823843002: Add openvr_device.h and openvr_device_provider.h into BUILD.gn (Closed)

Created:
3 years, 8 months ago by nhu
Modified:
3 years, 8 months ago
Reviewers:
bajones, billorr
CC:
chromium-reviews, feature-vr-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add openvr_device.h and openvr_device_provider.h into BUILD.gn BUG=712165 Review-Url: https://codereview.chromium.org/2823843002 Cr-Commit-Position: refs/heads/master@{#464974} Committed: https://chromium.googlesource.com/chromium/src/+/e585f9bcd2189fbfa2e9bc8bdafad9c0af1f3047

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M device/vr/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
nhu
PTAL. Thanks!
3 years, 8 months ago (2017-04-17 13:47:49 UTC) #3
billorr
non-owner LGTM, you'll still need bajones to sign-off
3 years, 8 months ago (2017-04-17 17:57:16 UTC) #4
bajones
On 2017/04/17 17:57:16, billorr wrote: > non-owner LGTM, you'll still need bajones to sign-off LGTM. ...
3 years, 8 months ago (2017-04-17 18:11:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2823843002/1
3 years, 8 months ago (2017-04-17 18:12:27 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-17 19:23:55 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e585f9bcd2189fbfa2e9bc8bdafa...

Powered by Google App Engine
This is Rietveld 408576698