Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 2823823002: Revert of [Payments] move //components/payments/content/*.mojom files to //components/payments/mojom (Closed)

Created:
3 years, 8 months ago by Tobias Sargeant
Modified:
3 years, 8 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, kinuko+watch, jsbell+serviceworker_chromium.org, tzik, jam, abarth-chromium, dglazkov+blink, darin-cc_chromium.org, blink-reviews, gogerald+paymentswatch_chromium.org, blink-worker-reviews_chromium.org, mlamouri+watch-content_chromium.org, nhiroki, rouslan+payments_chromium.org, haraken, michaeln, shimazu+serviceworker_chromium.org, serviceworker-reviews, blink-reviews-api_chromium.org, Aaron Boodman, kinuko+serviceworker, mahmadi+paymentswatch_chromium.org, horo+watch_chromium.org, darin (slow to review), sebsg+paymentswatch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Payments] move //components/payments/content/*.mojom files to //components/payments/mojom (patchset #7 id:200001 of https://codereview.chromium.org/2811593009/ ) Reason for revert: I suspect this caused build failures: crbug.com/712120 Original issue's description: > move //components/payments/content/*.mojom files to //components/payments/mojom > > To break dependency of //components/webdata_services on //components/payments/content after > landing https://codereview.chromium.org/2801513002/ > > BUG=711952 > > Review-Url: https://codereview.chromium.org/2811593009 > Cr-Original-Original-Commit-Position: refs/heads/master@{#464877} > Committed: https://chromium.googlesource.com/chromium/src/+/b1b326893990633387f90546607ce8271d151a3a > Review-Url: https://codereview.chromium.org/2811593009 > Cr-Original-Commit-Position: refs/heads/master@{#464882} > Committed: https://chromium.googlesource.com/chromium/src/+/3e1cedb46b52e6c09243993671a5a0ddb7a4eeed > Review-Url: https://codereview.chromium.org/2811593009 > Cr-Commit-Position: refs/heads/master@{#464892} > Committed: https://chromium.googlesource.com/chromium/src/+/7ea59a953395e7a90ba8dce7f908cd06a69f180f TBR=rouslan@chromium.org,cpu@chromium.org,dcheng@chromium.org,gogerald@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=711952 Review-Url: https://codereview.chromium.org/2823823002 Cr-Commit-Position: refs/heads/master@{#464910} Committed: https://chromium.googlesource.com/chromium/src/+/6ab92fb52c0b4e0fcb4dc9746e05189dc49b748b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+407 lines, -410 lines) Patch
M chrome/android/BUILD.gn View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/android/payments/service_worker_payment_app_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/payments/payment_request_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/payments/payment_request_browsertest_base.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/payments/payment_request_views_util.h View 1 chunk +1 line, -1 line 0 comments Download
M components/payments/android/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/payments/android/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M components/payments/android/web_app_manifest_section_table.h View 1 chunk +1 line, -1 line 0 comments Download
M components/payments/content/BUILD.gn View 4 chunks +34 lines, -4 lines 0 comments Download
A components/payments/content/OWNERS View 1 chunk +4 lines, -0 lines 0 comments Download
M components/payments/content/android/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download
M components/payments/content/android/payment_details_validation_android.cc View 1 chunk +1 line, -1 line 0 comments Download
A components/payments/content/payment_app.mojom View 1 chunk +57 lines, -0 lines 0 comments Download
M components/payments/content/payment_details_validation.h View 1 chunk +1 line, -1 line 0 comments Download
M components/payments/content/payment_details_validation.cc View 1 chunk +1 line, -1 line 0 comments Download
A components/payments/content/payment_manifest_parser.mojom View 1 chunk +25 lines, -0 lines 0 comments Download
M components/payments/content/payment_manifest_parser_host.h View 1 chunk +1 line, -1 line 0 comments Download
M components/payments/content/payment_request.h View 1 chunk +1 line, -1 line 0 comments Download
A components/payments/content/payment_request.mojom View 1 chunk +223 lines, -0 lines 0 comments Download
M components/payments/content/payment_request_spec.h View 1 chunk +1 line, -1 line 0 comments Download
M components/payments/content/payment_request_spec_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/payments/content/payment_request_state.h View 1 chunk +1 line, -1 line 0 comments Download
M components/payments/content/payment_request_state_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/payments/content/payment_request_web_contents_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M components/payments/content/payment_response_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M components/payments/content/payment_response_helper_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/payments/content/payments_validators.h View 1 chunk +1 line, -1 line 0 comments Download
M components/payments/content/utility/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/payments/content/utility/payment_manifest_parser.h View 1 chunk +1 line, -1 line 0 comments Download
D components/payments/mojom/BUILD.gn View 1 chunk +0 lines, -33 lines 0 comments Download
D components/payments/mojom/OWNERS View 1 chunk +0 lines, -4 lines 0 comments Download
D components/payments/mojom/payment_app.mojom View 1 chunk +0 lines, -57 lines 0 comments Download
D components/payments/mojom/payment_manifest_parser.mojom View 1 chunk +0 lines, -25 lines 0 comments Download
D components/payments/mojom/payment_request.mojom View 1 chunk +0 lines, -223 lines 0 comments Download
M content/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/payments/payment_app_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/payments/payment_app_content_unittest_base.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/payments/payment_app_context_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/payments/payment_app_database.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/payments/payment_app_provider_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/payments/payment_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/payments/payment_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/common/service_worker/service_worker_event_dispatcher.mojom View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/payment_app_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/service_worker/service_worker_context_client.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/service_worker/service_worker_type_converters.h View 1 chunk +1 line, -1 line 0 comments Download
M content/test/BUILD.gn View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/payments/resources/payment-request-mock.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/payments/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentAddress.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentManager.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentRequest.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentResponse.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentTestHelper.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentsValidators.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/public/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Tobias Sargeant
Created Revert of [Payments] move //components/payments/content/*.mojom files to //components/payments/mojom
3 years, 8 months ago (2017-04-17 08:53:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2823823002/1
3 years, 8 months ago (2017-04-17 08:53:46 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/6ab92fb52c0b4e0fcb4dc9746e05189dc49b748b
3 years, 8 months ago (2017-04-17 08:55:14 UTC) #6
Tobias Sargeant
3 years, 8 months ago (2017-04-17 13:37:24 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2822973002/ by tobiasjs@chromium.org.

The reason for reverting is: The reason appears to have been a synchronization
issue with the official builds. Undoing the revert..

Powered by Google App Engine
This is Rietveld 408576698