Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 2823803004: [M58 merge] Block domain labels made of Cyrillic letters that look alike Latin (Closed)

Created:
3 years, 8 months ago by awhalley
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

[M58 merge] Block domain labels made of Cyrillic letters that look alike Latin Block a label made entirely of Latin-look-alike Cyrillic letters when the TLD is not an IDN (i.e. this check is ON only for TLDs like 'com', 'net', 'uk', but not applied for IDN TLDs like рф. BUG=683314 TEST=components_unittests --gtest_filter=U*IDN* Review-Url: https://codereview.chromium.org/2683793010 Cr-Commit-Position: refs/heads/master@{#459226} (cherry picked from commit 08cb718ba7c3961c1006176c9faba0a5841ec792) Review-Url: https://codereview.chromium.org/2823803004 . Cr-Commit-Position: refs/branch-heads/3029@{#734} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/4024314edf638036da208e40e7b3998ae1feec6d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -16 lines) Patch
M components/url_formatter/url_formatter.cc View 11 chunks +63 lines, -16 lines 0 comments Download
M components/url_formatter/url_formatter_unittest.cc View 2 chunks +30 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
awhalley
3 years, 8 months ago (2017-04-17 17:09:56 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4024314edf638036da208e40e7b3998ae1feec6d.

Powered by Google App Engine
This is Rietveld 408576698