Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 2823753002: Remove device light API

Created:
3 years, 8 months ago by cco3
Modified:
3 years, 7 months ago
Reviewers:
riju_, foolip
CC:
chromium-reviews, blink-reviews-w3ctests_chromium.org, mlamouri+watch-blink_chromium.org, timvolodine, haraken, blink-reviews-bindings_chromium.org, blink-reviews, kinuko+watch, Reilly Grant (use Gerrit)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove device light API DeviceLightEvent is no longer on track for standardization, which means it will not ship in Blink. BUG=711577, 336424

Patch Set 1 #

Total comments: 2

Patch Set 2 : Restore DeviceLightEvent to LayoutTests/external/wpt/dom/nodes/Document-createEvent.html #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -652 lines) Patch
D third_party/WebKit/LayoutTests/ambient-light/add-listener.html View 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/WebKit/LayoutTests/ambient-light/add-listener-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/ambient-light/create-event.html View 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/WebKit/LayoutTests/ambient-light/create-event-expected.txt View 1 chunk +0 lines, -20 lines 0 comments Download
D third_party/WebKit/LayoutTests/ambient-light/multiple-event-listeners.html View 1 chunk +0 lines, -86 lines 0 comments Download
D third_party/WebKit/LayoutTests/ambient-light/multiple-event-listeners-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/ambient-light/page-visibility.html View 1 chunk +0 lines, -51 lines 0 comments Download
D third_party/WebKit/LayoutTests/ambient-light/page-visibility-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/WebKit/LayoutTests/ambient-light/window-property.html View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/ambient-light/window-property-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/dom/nodes/Document-createEvent-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/bindings/modules/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/Source/modules/device_light/BUILD.gn View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/WebKit/Source/modules/device_light/DEPS View 1 chunk +0 lines, -7 lines 0 comments Download
D third_party/WebKit/Source/modules/device_light/DOMWindowDeviceLight.h View 1 chunk +0 lines, -19 lines 0 comments Download
D third_party/WebKit/Source/modules/device_light/DeviceLightController.h View 1 chunk +0 lines, -45 lines 0 comments Download
D third_party/WebKit/Source/modules/device_light/DeviceLightController.cpp View 1 chunk +0 lines, -67 lines 0 comments Download
D third_party/WebKit/Source/modules/device_light/DeviceLightDispatcher.h View 1 chunk +0 lines, -45 lines 0 comments Download
D third_party/WebKit/Source/modules/device_light/DeviceLightDispatcher.cpp View 1 chunk +0 lines, -44 lines 0 comments Download
D third_party/WebKit/Source/modules/device_light/DeviceLightEvent.h View 1 chunk +0 lines, -48 lines 0 comments Download
D third_party/WebKit/Source/modules/device_light/DeviceLightEvent.cpp View 1 chunk +0 lines, -29 lines 0 comments Download
D third_party/WebKit/Source/modules/device_light/DeviceLightEvent.idl View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/WebKit/Source/modules/device_light/DeviceLightEventInit.idl View 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/WebKit/Source/modules/device_light/WindowDeviceLight.idl View 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/modules/modules_idl_files.gni View 4 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/web/LocalFrameClientImpl.cpp View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
cco3
3 years, 8 months ago (2017-04-15 01:27:28 UTC) #2
cco3
Hi foolip@, I saw the issue you filed. Is this what you had in mind?
3 years, 8 months ago (2017-04-15 01:28:28 UTC) #3
foolip
Adding riju as reviewer also.
3 years, 8 months ago (2017-04-17 08:50:38 UTC) #5
foolip
On 2017/04/15 01:28:28, cco3 wrote: > Hi foolip@, I saw the issue you filed. Is ...
3 years, 8 months ago (2017-04-17 08:50:50 UTC) #6
foolip
lgtm % wpt test, and I'd like riju to sign off on this as well. ...
3 years, 8 months ago (2017-04-17 08:55:59 UTC) #7
cco3
https://codereview.chromium.org/2823753002/diff/1/third_party/WebKit/LayoutTests/external/wpt/dom/nodes/Document-createEvent.html File third_party/WebKit/LayoutTests/external/wpt/dom/nodes/Document-createEvent.html (left): https://codereview.chromium.org/2823753002/diff/1/third_party/WebKit/LayoutTests/external/wpt/dom/nodes/Document-createEvent.html#oldcode84 third_party/WebKit/LayoutTests/external/wpt/dom/nodes/Document-createEvent.html:84: "DeviceLightEvent", On 2017/04/17 08:55:59, foolip_UTC7 wrote: > Actually it's ...
3 years, 8 months ago (2017-04-17 16:53:19 UTC) #8
riju_
This change looks good, but I would wait for some time to get an answer ...
3 years, 8 months ago (2017-04-19 08:12:40 UTC) #9
foolip
3 years, 7 months ago (2017-04-27 08:14:27 UTC) #10
There's a duplicate review at https://codereview.chromium.org/2845763002/ now.
The way to avoid that is to assign bugs to yourself, or to comment with a link
to an ongoing review on the bug. Sorry I didn't notice this myself when I began
poking Edge and Firefox for input.

Powered by Google App Engine
This is Rietveld 408576698