Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2823743002: Revert of [Mac] The infobar's top arrow should be hidden while the omnibox popup is shown (Closed)

Created:
3 years, 8 months ago by skym
Modified:
3 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Mac] The infobar's top arrow should be hidden while the omnibox popup is shown (patchset #7 id:120001 of https://codereview.chromium.org/2196203002/ ) Reason for revert: Causing sync integ tests to fail, see crbug.com/711791 Original issue's description: > [Mac] The infobar's top arrow should be hidden while the omnibox popup is shown > > Unlike on Windows, the infobar's top arrow still remains on a screen even after > the omnibox popup is displayed over it. This CL fixes this problem based on the > idea (https://codereview.chromium.org/18859004) previously applied to Windows > version. > > BUG=174077 > > Review-Url: https://codereview.chromium.org/2196203002 > Cr-Commit-Position: refs/heads/master@{#464700} > Committed: https://chromium.googlesource.com/chromium/src/+/d1040f6d95719c52a3ec442c76be29d5c0630bf4 TBR=rsesek@chromium.org,pkasting@chromium.org,sungmann.cho@navercorp.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=174077 Review-Url: https://codereview.chromium.org/2823743002 Cr-Commit-Position: refs/heads/master@{#464837} Committed: https://chromium.googlesource.com/chromium/src/+/19cb28b93a365b58b6ec3f8092ea3c4562c71621

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -53 lines) Patch
M chrome/browser/ui/cocoa/browser_window_controller.h View 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller.mm View 5 chunks +0 lines, -45 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
skym
Created Revert of [Mac] The infobar's top arrow should be hidden while the omnibox popup ...
3 years, 8 months ago (2017-04-15 00:19:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2823743002/1
3 years, 8 months ago (2017-04-15 00:19:24 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-15 00:22:04 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/19cb28b93a365b58b6ec3f8092ea...

Powered by Google App Engine
This is Rietveld 408576698