Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2823653002: Adjust expectations for external/wpt/XMLHttpRequest/event-readystatechange-loaded.htm (Closed)

Created:
3 years, 8 months ago by alexmos
Modified:
3 years, 8 months ago
Reviewers:
qyearsley
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Adjust expectations for external/wpt/XMLHttpRequest/event-readystatechange-loaded.htm This test was imported with an expectation of Timeout, but apparently it can also fail with a text diff on a couple of platforms (WebKit Linux Trusty (dbg) and WebKit Mac10.11 (dbg)). Adjust the expectation accordingly. See https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&tests=external%2Fwpt%2FXMLHttpRequest%2Fevent-readystatechange-loaded.htm BUG=626703 NOTRY=true TBR=qyearsley@chromium.org Review-Url: https://codereview.chromium.org/2823653002 Cr-Commit-Position: refs/heads/master@{#464787} Committed: https://chromium.googlesource.com/chromium/src/+/0a60ba07a67b887c7799cae5eb572e8d6936dc25

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
alexmos
qyearsley@ - does this make sense? Your https://chromium.googlesource.com/chromium/src/+/16fa46a1db956be40c199add90817ca5ef34a6f0 introduced the test and its expectation.
3 years, 8 months ago (2017-04-14 19:34:57 UTC) #2
alexmos
I'll go ahead and land this to get the bots green, but please let me ...
3 years, 8 months ago (2017-04-14 20:23:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2823653002/1
3 years, 8 months ago (2017-04-14 20:24:02 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/0a60ba07a67b887c7799cae5eb572e8d6936dc25
3 years, 8 months ago (2017-04-14 20:28:59 UTC) #10
qyearsley
3 years, 8 months ago (2017-04-14 20:32:45 UTC) #11
Message was sent while issue was closed.
LGTM and thanks!

Powered by Google App Engine
This is Rietveld 408576698