MD Settings: Network: Provide default WiFi network

MD Settings: Network: Provide default WiFi network

All Chrome OS devices have WiFi, which is typically enabled.

This CL initializes CrNetworkSummary with a WiFi entry so
that in the typical case there is less change between the
initial page layout and when the network state information
arrives from Chrome.

BUG=704042
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2823563004
Cr-Commit-Position: refs/heads/master@{#465453}
Committed: https://chromium.googlesource.com/chromium/src/+/ac063b434a2dbfe7bb777fc5fc0bfade5db9aa49

[stevenjb, 2017-04-14 19:45:40]

Description was changed from

==========
MD Settings: Network: Provide default WiFi network

All Chrome OS devices have WiFi, which is typically enabled.

This CL initializes CrNetworkSummary with a WiFi entry so
that in the typical case there is less change between the
initial page layout and when the network state information
arrives from Chrome.

BUG=704042
==========

to

==========
MD Settings: Network: Provide default WiFi network

All Chrome OS devices have WiFi, which is typically enabled.

This CL initializes CrNetworkSummary with a WiFi entry so
that in the typical case there is less change between the
initial page layout and when the network state information
arrives from Chrome.

BUG=704042
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[stevenjb, 2017-04-14 19:47:20]

stevenjb@chromium.org changed reviewers:
+ michaelpg@chromium.org

[michaelpg, 2017-04-14 20:53:46]

In general, I think we should only pre-populate correct information. Which this
CL is a step toward, but in some ways a regression. On a low-end Chromebook, how
long might the network section show a misleading status with this patch before
the page finishes loading?

Could we set loadTimeData with the GUID of the connected wi-fi network via
cached NetworkStateHandler properties?

https://codereview.chromium.org/2823563004/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/internet_page/network_summary.js (right):

https://codereview.chromium.org/2823563004/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/internet_page/network_summary.js:60: * usually
disabled. This reduces the amount of visual change on first load.
"enabled"?

[stevenjb, 2017-04-14 21:06:05]

On 2017/04/14 20:53:46, michaelpg wrote:
> In general, I think we should only pre-populate correct information. Which
this
> CL is a step toward, but in some ways a regression. On a low-end Chromebook,
how
> long might the network section show a misleading status with this patch before
> the page finishes loading?
> 
> Could we set loadTimeData with the GUID of the connected wi-fi network via
> cached NetworkStateHandler properties?
> 
>
https://codereview.chromium.org/2823563004/diff/1/chrome/browser/resources/se...
> File chrome/browser/resources/settings/internet_page/network_summary.js
(right):
> 
>
https://codereview.chromium.org/2823563004/diff/1/chrome/browser/resources/se...
> chrome/browser/resources/settings/internet_page/network_summary.js:60: *
usually
> disabled. This reduces the amount of visual change on first load.
> "enabled"?

I'm pretty wary of hacks like using loadTimeData. The C++ code is synchronous,
so even on a low end device we are only talking about a frame or two. That said,
the concern about misleading information is valid. You can tell from the comment
that I went back and forth between starting disabled vs enabled; I think I will
change this to disabled since it is arguably less misleading; it's the size
change that is most visible.

[stevenjb, 2017-04-14 21:30:53]

https://codereview.chromium.org/2823563004/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/internet_page/network_summary.js (right):

https://codereview.chromium.org/2823563004/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/internet_page/network_summary.js:60: * usually
disabled. This reduces the amount of visual change on first load.
On 2017/04/14 20:53:46, michaelpg wrote:
> "enabled"?

Done.

[michaelpg, 2017-04-14 22:31:58]

lgtm

[stevenjb, 2017-04-18 23:05:55]

The CQ bit was checked by stevenjb@chromium.org

[stevenjb, 2017-04-18 23:05:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaelpg@chromium.org
Link to the patchset: https://codereview.chromium.org/2823563004/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2017-04-18 23:06:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 01:09:36]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492556755311460,
"parent_rev": "76259cd66b9138f4fc474b955ed035d0f27e7dd4", "commit_rev":
"ac063b434a2dbfe7bb777fc5fc0bfade5db9aa49"}

[commit-bot: I haz the power, 2017-04-19 01:09:51]

Description was changed from

==========
MD Settings: Network: Provide default WiFi network

All Chrome OS devices have WiFi, which is typically enabled.

This CL initializes CrNetworkSummary with a WiFi entry so
that in the typical case there is less change between the
initial page layout and when the network state information
arrives from Chrome.

BUG=704042
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Network: Provide default WiFi network

All Chrome OS devices have WiFi, which is typically enabled.

This CL initializes CrNetworkSummary with a WiFi entry so
that in the typical case there is less change between the
initial page layout and when the network state information
arrives from Chrome.

BUG=704042
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2823563004
Cr-Commit-Position: refs/heads/master@{#465453}
Committed:
https://chromium.googlesource.com/chromium/src/+/ac063b434a2dbfe7bb777fc5fc0b...
==========

[commit-bot: I haz the power, 2017-04-19 01:09:52]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/ac063b434a2dbfe7bb777fc5fc0b...