Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issue 2823563004: MD Settings: Network: Provide default WiFi network (Closed)

Created:
3 years, 8 months ago by stevenjb
Modified:
3 years, 8 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Network: Provide default WiFi network All Chrome OS devices have WiFi, which is typically enabled. This CL initializes CrNetworkSummary with a WiFi entry so that in the typical case there is less change between the initial page layout and when the network state information arrives from Chrome. BUG=704042 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2823563004 Cr-Commit-Position: refs/heads/master@{#465453} Committed: https://chromium.googlesource.com/chromium/src/+/ac063b434a2dbfe7bb777fc5fc0bfade5db9aa49

Patch Set 1 #

Total comments: 2

Patch Set 2 : Feedback #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M chrome/browser/resources/settings/internet_page/network_summary.js View 1 2 chunks +13 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
stevenjb
3 years, 8 months ago (2017-04-14 19:47:21 UTC) #3
michaelpg
In general, I think we should only pre-populate correct information. Which this CL is a ...
3 years, 8 months ago (2017-04-14 20:53:46 UTC) #4
stevenjb
On 2017/04/14 20:53:46, michaelpg wrote: > In general, I think we should only pre-populate correct ...
3 years, 8 months ago (2017-04-14 21:06:05 UTC) #5
stevenjb
https://codereview.chromium.org/2823563004/diff/1/chrome/browser/resources/settings/internet_page/network_summary.js File chrome/browser/resources/settings/internet_page/network_summary.js (right): https://codereview.chromium.org/2823563004/diff/1/chrome/browser/resources/settings/internet_page/network_summary.js#newcode60 chrome/browser/resources/settings/internet_page/network_summary.js:60: * usually disabled. This reduces the amount of visual ...
3 years, 8 months ago (2017-04-14 21:30:53 UTC) #6
michaelpg
lgtm
3 years, 8 months ago (2017-04-14 22:31:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2823563004/40001
3 years, 8 months ago (2017-04-18 23:06:43 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 01:09:52 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/ac063b434a2dbfe7bb777fc5fc0b...

Powered by Google App Engine
This is Rietveld 408576698