Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Issue 2823563003: asan symbolize: Restore invalid utf-8 ignorance. (Closed)

Created:
3 years, 8 months ago by Nico
Modified:
3 years, 8 months ago
Reviewers:
Vadim Sh.
CC:
chromium-reviews, glider+watch_chromium.org, bruening+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

asan symbolize: Restore invalid utf-8 ignorance. This was removed in https://codereview.chromium.org/2818653003/diff/1/tools/valgrind/asan/asan_symbolize.py but apparently tests do write invalid UTF-8 (maybe on Windows they write output in the native codepage by default?). Having stacks seems more important atm. BUG=632047 TBR=vadimsh@chromium.org Review-Url: https://codereview.chromium.org/2823563003 Cr-Commit-Position: refs/heads/master@{#464730} Committed: https://chromium.googlesource.com/chromium/src/+/9d47da2334d77bd084aef8e0d5765a47967d449a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/valgrind/asan/asan_symbolize.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Nico
3 years, 8 months ago (2017-04-14 14:49:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2823563003/1
3 years, 8 months ago (2017-04-14 14:49:30 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/9d47da2334d77bd084aef8e0d5765a47967d449a
3 years, 8 months ago (2017-04-14 15:47:00 UTC) #6
Vadim Sh.
3 years, 8 months ago (2017-04-14 17:14:03 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698