Unified error handling for WritableStream

Unified error handling for WritableStream

Port the standard changes in
https://github.com/whatwg/streams/pull/721.

There are a number of behavioural changes related to error handling, which are
listed at the above URL. This implementation has no known deviations from the
standard.

The brings this implementation up to parity with
https://github.com/whatwg/streams/commit/e7bf9293d3e0b26f9221dada3723e31707db8c32.

This CL also removes failing test expectations. Issue 626703 and 711529 cover lines
that were removed from TestExpectations.

BUG=711254, 626703, 711529, 684543
Review-Url: https://codereview.chromium.org/2823563002
Cr-Commit-Position: refs/heads/master@{#465498}
Committed: https://chromium.googlesource.com/chromium/src/+/6703f4df6ad92a629ea4ac736f6ff26402ef139e

[Adam Rice, 2017-04-14 14:59:48]

The CQ bit was checked by ricea@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-14 14:59:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Adam Rice, 2017-04-14 15:07:06]

Description was changed from

==========
Unified error handling for WritableStream

Port the standard changes in
https://github.com/whatwg/streams/pull/721.

There are a number of behavioural changes related to error handling, which are
listed at the above URL. This implementation has no known deviations from the
standard.

The brings this implementation up to parity with
https://github.com/whatwg/streams/commit/e7bf9293d3e0b26f9221dada3723e31707db....

BUG=711254
==========

to

==========
Unified error handling for WritableStream

Port the standard changes in
https://github.com/whatwg/streams/pull/721.

There are a number of behavioural changes related to error handling, which are
listed at the above URL. This implementation has no known deviations from the
standard.

The brings this implementation up to parity with
https://github.com/whatwg/streams/commit/e7bf9293d3e0b26f9221dada3723e31707db....

This CL also removes failing test expectations. Issues 626703 and 711529 are
associated with lines that were removed from TestExpectations.

BUG=711254,626703,711529
==========

[commit-bot: I haz the power, 2017-04-14 16:31:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-14 16:31:10]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Adam Rice, 2017-04-17 08:40:04]

The CQ bit was checked by ricea@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-17 08:40:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Adam Rice, 2017-04-17 09:28:02]

ricea@chromium.org changed reviewers:
+ domenic@chromium.org, tyoshino@chromium.org

[Adam Rice, 2017-04-17 09:28:03]

I think this is good to go now. Please review.

[Adam Rice, 2017-04-17 09:30:46]

Description was changed from

==========
Unified error handling for WritableStream

Port the standard changes in
https://github.com/whatwg/streams/pull/721.

There are a number of behavioural changes related to error handling, which are
listed at the above URL. This implementation has no known deviations from the
standard.

The brings this implementation up to parity with
https://github.com/whatwg/streams/commit/e7bf9293d3e0b26f9221dada3723e31707db....

This CL also removes failing test expectations. Issues 626703 and 711529 are
associated with lines that were removed from TestExpectations.

BUG=711254,626703,711529
==========

to

==========
Unified error handling for WritableStream

Port the standard changes in
https://github.com/whatwg/streams/pull/721.

There are a number of behavioural changes related to error handling, which are
listed at the above URL. This implementation has no known deviations from the
standard.

The brings this implementation up to parity with
https://github.com/whatwg/streams/commit/e7bf9293d3e0b26f9221dada3723e31707db....

This CL also removes failing test expectations.lines that were removed from
TestExpectations.

BUG=711254
==========

[commit-bot: I haz the power, 2017-04-17 10:08:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-17 10:08:40]

Dry run: This issue passed the CQ dry run.

[domenic, 2017-04-17 22:20:28]

lgtm!!

A little unclear how this will interact with the "remove asserts" CL, but seems
solid.

I wonder if we want to request merging this back into the branch. It seems OK if
we don't since it's edge-cases.

https://codereview.chromium.org/2823563002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/streams/WritableStream.js (right):

https://codereview.chromium.org/2823563002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/streams/WritableStream.js:48: const ERRORED = 3;
I guess the tests prove me wrong, but I would have thought this would have to be
a power of 2.

https://codereview.chromium.org/2823563002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/streams/WritableStream.js:492: case WRITABLE:
Nit: I personally like wrapping {}s around my case blocks (and indenting);
especially with let/const, that works out quite nicely.

[Adam Rice, 2017-04-18 02:49:03]

The CQ bit was checked by ricea@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 02:49:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Adam Rice, 2017-04-18 02:55:31]

On 2017/04/17 22:20:28, domenic wrote:
> A little unclear how this will interact with the "remove asserts" CL, but
seems
> solid.

It should apply cleanly on top.

> I wonder if we want to request merging this back into the branch. It seems OK
if
> we don't since it's edge-cases.

I have a few reasons for wanting to do this:

* The current version of the standard is the one I want browsers to ship. It
would
  be hypocritical to ship an older version myself.
* I don't like shipping a version that fails a lot of web-platform-tests. This
also
  has real consequences since the test results show up on web-platform-tests
pull
  requests.
* If we need to apply bug fixes later it's easier if the release branch matches
  trunk.

[Adam Rice, 2017-04-18 02:55:45]

https://codereview.chromium.org/2823563002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/streams/WritableStream.js (right):

https://codereview.chromium.org/2823563002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/streams/WritableStream.js:48: const ERRORED = 3;
On 2017/04/17 22:20:28, domenic wrote:
> I guess the tests prove me wrong, but I would have thought this would have to
be
> a power of 2.

Only one state is active at a time. That's why they don't need to be powers of
2.

https://codereview.chromium.org/2823563002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/streams/WritableStream.js:492: case WRITABLE:
On 2017/04/17 22:20:28, domenic wrote:
> Nit: I personally like wrapping {}s around my case blocks (and indenting);
> especially with let/const, that works out quite nicely.

Done. Looks better. I was concerned that this was unreadable.

[tyoshino (SeeGerritForStatus), 2017-04-18 04:32:46]

lgtm

[commit-bot: I haz the power, 2017-04-18 05:23:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 05:23:54]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Adam Rice, 2017-04-18 06:40:53]

The CQ bit was checked by ricea@chromium.org

[Adam Rice, 2017-04-18 06:40:53]

The patchset sent to the CQ was uploaded after l-g-t-m from domenic@chromium.org
Link to the patchset: https://codereview.chromium.org/2823563002/#ps100001
(title: "Wrap case statements in blocks")

[commit-bot: I haz the power, 2017-04-18 06:41:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 10:08:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 10:08:24]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Adam Rice, 2017-04-19 01:20:18]

The CQ bit was checked by ricea@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 01:20:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Adam Rice, 2017-04-19 01:22:15]

Description was changed from

==========
Unified error handling for WritableStream

Port the standard changes in
https://github.com/whatwg/streams/pull/721.

There are a number of behavioural changes related to error handling, which are
listed at the above URL. This implementation has no known deviations from the
standard.

The brings this implementation up to parity with
https://github.com/whatwg/streams/commit/e7bf9293d3e0b26f9221dada3723e31707db....

This CL also removes failing test expectations.lines that were removed from
TestExpectations.

BUG=711254
==========

to

==========
Unified error handling for WritableStream

Port the standard changes in
https://github.com/whatwg/streams/pull/721.

There are a number of behavioural changes related to error handling, which are
listed at the above URL. This implementation has no known deviations from the
standard.

The brings this implementation up to parity with
https://github.com/whatwg/streams/commit/e7bf9293d3e0b26f9221dada3723e31707db....

This CL also removes failing test expectations. Issue 626703 covers lines that
were removed from TestExpectations.

BUG=711254,626703
==========

[commit-bot: I haz the power, 2017-04-19 03:00:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 03:00:39]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Adam Rice, 2017-04-19 03:36:24]

The CQ bit was checked by ricea@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 03:36:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Adam Rice, 2017-04-19 03:38:19]

Description was changed from

==========
Unified error handling for WritableStream

Port the standard changes in
https://github.com/whatwg/streams/pull/721.

There are a number of behavioural changes related to error handling, which are
listed at the above URL. This implementation has no known deviations from the
standard.

The brings this implementation up to parity with
https://github.com/whatwg/streams/commit/e7bf9293d3e0b26f9221dada3723e31707db....

This CL also removes failing test expectations. Issue 626703 covers lines that
were removed from TestExpectations.

BUG=711254,626703
==========

to

==========
Unified error handling for WritableStream

Port the standard changes in
https://github.com/whatwg/streams/pull/721.

There are a number of behavioural changes related to error handling, which are
listed at the above URL. This implementation has no known deviations from the
standard.

The brings this implementation up to parity with
https://github.com/whatwg/streams/commit/e7bf9293d3e0b26f9221dada3723e31707db....

This CL also removes failing test expectations. Issue 626703 and 711529 cover
lines
that were removed from TestExpectations.

BUG=711254,626703,711529,684543
==========

[commit-bot: I haz the power, 2017-04-19 05:07:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 05:07:45]

Dry run: This issue passed the CQ dry run.

[Adam Rice, 2017-04-19 05:24:34]

The CQ bit was checked by ricea@chromium.org

[Adam Rice, 2017-04-19 05:24:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
tyoshino@chromium.org, domenic@chromium.org
Link to the patchset: https://codereview.chromium.org/2823563002/#ps150001
(title: "remove local copy of piping/multiple-propagation test as it is fail")

[commit-bot: I haz the power, 2017-04-19 05:24:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 05:29:20]

CQ is committing da patch.

Bot data: {"patchset_id": 150001, "attempt_start_ts": 1492579474179190,
"parent_rev": "baea08206b03227c71eeafa328185c5741f4f2e5", "commit_rev":
"6703f4df6ad92a629ea4ac736f6ff26402ef139e"}

[commit-bot: I haz the power, 2017-04-19 05:30:19]

Description was changed from

==========
Unified error handling for WritableStream

Port the standard changes in
https://github.com/whatwg/streams/pull/721.

There are a number of behavioural changes related to error handling, which are
listed at the above URL. This implementation has no known deviations from the
standard.

The brings this implementation up to parity with
https://github.com/whatwg/streams/commit/e7bf9293d3e0b26f9221dada3723e31707db....

This CL also removes failing test expectations. Issue 626703 and 711529 cover
lines
that were removed from TestExpectations.

BUG=711254,626703,711529,684543
==========

to

==========
Unified error handling for WritableStream

Port the standard changes in
https://github.com/whatwg/streams/pull/721.

There are a number of behavioural changes related to error handling, which are
listed at the above URL. This implementation has no known deviations from the
standard.

The brings this implementation up to parity with
https://github.com/whatwg/streams/commit/e7bf9293d3e0b26f9221dada3723e31707db....

This CL also removes failing test expectations. Issue 626703 and 711529 cover
lines
that were removed from TestExpectations.

BUG=711254,626703,711529,684543

Review-Url: https://codereview.chromium.org/2823563002
Cr-Commit-Position: refs/heads/master@{#465498}
Committed:
https://chromium.googlesource.com/chromium/src/+/6703f4df6ad92a629ea4ac736f6f...
==========

[commit-bot: I haz the power, 2017-04-19 05:30:20]

Committed patchset #9 (id:150001) as
https://chromium.googlesource.com/chromium/src/+/6703f4df6ad92a629ea4ac736f6f...