[Page Load Metrics] PageLoadMetrics Mojofication.

chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc

Index: chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc
diff --git a/chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc b/chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc
index 95ae2c28a875e85f8e3077b1645cabfc30997602..7269ae03b721237a3c6f61bc9162fa15a5972466 100644
--- a/chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc
+++ b/chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc
@@ -10,6 +10,7 @@
 #include "base/time/time.h"
 #include "base/timer/timer.h"
 #include "chrome/renderer/page_load_metrics/page_timing_metrics_sender.h"
+#include "chrome/renderer/page_load_metrics/page_timing_sender.h"
 #include "chrome/renderer/page_load_metrics/renderer_page_track_decider.h"
 #include "chrome/renderer/searchbox/search_bouncer.h"
 #include "content/public/renderer/render_frame.h"
@@ -71,7 +72,7 @@ void MetricsRenderFrameObserver::DidCommitProvisionalLoad(
   // those metrics become available.
   if (ShouldSendMetrics()) {
     page_timing_metrics_sender_ = base::MakeUnique<PageTimingMetricsSender>(
-        this, routing_id(), CreateTimer(), GetTiming());
+        CreatePageTimingSender(), CreateTimer(), GetTiming());
   }
 }
 
@@ -167,6 +168,11 @@ std::unique_ptr<base::Timer> MetricsRenderFrameObserver::CreateTimer() const {
   return base::WrapUnique(new base::OneShotTimer);
 }
 
+std::unique_ptr<PageTimingSender>
+MetricsRenderFrameObserver::CreatePageTimingSender() {
+  return PageTimingSender::CreatePageTimingSender(render_frame(), routing_id());

[Bryan McQuade, 2017/05/19 14:06:18]

given that the static PageTimingSender::CreatePageTimingSender method is only
called in this one place, I'd rather that we inline it into this method, and
move the IPC and Mojo sender impls to an anonymous namespace in this file.

[lpy, 2017/05/19 23:52:38]

Done.

+}
+
 bool MetricsRenderFrameObserver::HasNoRenderFrame() const {
   bool no_frame = !render_frame() || !render_frame()->GetWebFrame();
   DCHECK(!no_frame);