[Page Load Metrics] PageLoadMetrics Mojofication.

chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/page_load_metrics/metrics_render_frame_observer.h"
 
 #include <string>
 
 #include "base/memory/ptr_util.h"
 #include "base/time/time.h"
 #include "base/timer/timer.h"
 #include "chrome/renderer/page_load_metrics/page_timing_metrics_sender.h"
+#include "chrome/renderer/page_load_metrics/page_timing_sender.h"
 #include "chrome/renderer/page_load_metrics/renderer_page_track_decider.h"
 #include "chrome/renderer/searchbox/search_bouncer.h"
 #include "content/public/renderer/render_frame.h"
 #include "third_party/WebKit/public/web/WebDataSource.h"
 #include "third_party/WebKit/public/web/WebDocument.h"
 #include "third_party/WebKit/public/web/WebLocalFrame.h"
 #include "third_party/WebKit/public/web/WebPerformance.h"
 #include "url/gurl.h"
 
 namespace page_load_metrics {
@@ skipping 41 matching lines @@
 
   // Make sure to release the sender for a previous navigation, if we have one.
   page_timing_metrics_sender_.reset();
 
   // We only create a PageTimingMetricsSender if the page meets the criteria for
   // sending and recording metrics. Once page_timing_metrics_sender_ is
   // non-null, we will send metrics for the current page at some later time, as
   // those metrics become available.
   if (ShouldSendMetrics()) {
     page_timing_metrics_sender_ = base::MakeUnique<PageTimingMetricsSender>(
-        this, routing_id(), CreateTimer(), GetTiming());
+        CreatePageTimingSender(), CreateTimer(), GetTiming());
   }
 }
 
 void MetricsRenderFrameObserver::SendMetrics() {
   if (!page_timing_metrics_sender_)
     return;
   if (HasNoRenderFrame())
     return;
   page_timing_metrics_sender_->Send(GetTiming());
 }
@@ skipping 75 matching lines @@
     timing->style_sheet_timing->update_style_duration_before_fcp =
         base::TimeDelta::FromSecondsD(perf.UpdateStyleDurationBeforeFCP());
   }
   return timing;
 }
 
 std::unique_ptr<base::Timer> MetricsRenderFrameObserver::CreateTimer() const {
   return base::WrapUnique(new base::OneShotTimer);
 }
 
+std::unique_ptr<PageTimingSender>
+MetricsRenderFrameObserver::CreatePageTimingSender() {
+  return PageTimingSender::CreatePageTimingSender(render_frame(), routing_id());

[Bryan McQuade, 2017/05/19 14:06:18]

given that the static PageTimingSender::CreatePageTimingSender method is only
called in this one place, I'd rather that we inline it into this method, and
move the IPC and Mojo sender impls to an anonymous namespace in this file.

[lpy, 2017/05/19 23:52:38]

Done.

+}
+
 bool MetricsRenderFrameObserver::HasNoRenderFrame() const {
   bool no_frame = !render_frame() || !render_frame()->GetWebFrame();
   DCHECK(!no_frame);
   return no_frame;
 }
 
 void MetricsRenderFrameObserver::OnDestruct() {
   delete this;
 }
 
 }  // namespace page_load_metrics