Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2132)

Unified Diff: chrome/browser/page_load_metrics/metrics_web_contents_observer.cc

Issue 2823523003: [Page Load Metrics] PageLoadMetrics Mojofication. (Closed)
Patch Set: Add unit test for page_load_metrics_struct_traits Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
diff --git a/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc b/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
index 044495e8c15477c6feb9d26f3b8e58b564fdebe0..531aae16f9aad52c1a3abbdb99c488a6f8029854 100644
--- a/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
+++ b/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
@@ -70,7 +70,8 @@ MetricsWebContentsObserver::MetricsWebContentsObserver(
: content::WebContentsObserver(web_contents),
in_foreground_(false),
embedder_interface_(std::move(embedder_interface)),
- has_navigated_(false) {
+ has_navigated_(false),
+ page_load_metrics_binding_(web_contents, this) {
RegisterInputEventObserver(web_contents->GetRenderViewHost());
}
@@ -610,6 +611,14 @@ void MetricsWebContentsObserver::OnTimingUpdated(
observer.OnTimingUpdated(timing, metadata);
}
+void MetricsWebContentsObserver::UpdateTiming(
+ const PageLoadTiming& timing,
+ const PageLoadMetadata& metadata) {
+ content::RenderFrameHost* render_frame_host =
Bryan McQuade 2017/05/07 19:48:13 can we DCHECK that the mojofication feature is ena
lpy 2017/05/08 18:38:33 Done.
+ page_load_metrics_binding_.GetCurrentTargetFrame();
+ OnTimingUpdated(render_frame_host, timing, metadata);
+}
+
bool MetricsWebContentsObserver::ShouldTrackNavigation(
content::NavigationHandle* navigation_handle) const {
DCHECK(navigation_handle->IsInMainFrame());

Powered by Google App Engine
This is Rietveld 408576698