[Page Load Metrics] PageLoadMetrics Mojofication.

chrome/browser/page_load_metrics/metrics_web_contents_observer.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/page_load_metrics/metrics_web_contents_observer.h"
 
 #include <algorithm>
 #include <ostream>
 #include <string>
 #include <utility>
@@ skipping 52 matching lines @@
 }
 
 }  // namespace
 
 MetricsWebContentsObserver::MetricsWebContentsObserver(
     content::WebContents* web_contents,
     std::unique_ptr<PageLoadMetricsEmbedderInterface> embedder_interface)
     : content::WebContentsObserver(web_contents),
       in_foreground_(false),
       embedder_interface_(std::move(embedder_interface)),
-      has_navigated_(false) {
+      has_navigated_(false),
+      page_load_metrics_binding_(web_contents, this) {
   RegisterInputEventObserver(web_contents->GetRenderViewHost());
 }
 
 // static
 MetricsWebContentsObserver* MetricsWebContentsObserver::CreateForWebContents(
     content::WebContents* web_contents,
     std::unique_ptr<PageLoadMetricsEmbedderInterface> embedder_interface) {
   DCHECK(web_contents);
 
   MetricsWebContentsObserver* metrics = FromWebContents(web_contents);
@@ skipping 519 matching lines @@
     committed_load_->UpdateChildFrameMetadata(metadata);
     return;
   }
 
   committed_load_->UpdateTiming(timing, metadata);
 
   for (auto& observer : testing_observers_)
     observer.OnTimingUpdated(timing, metadata);
 }
 
+void MetricsWebContentsObserver::UpdateTiming(
+    const PageLoadTiming& timing,
+    const PageLoadMetadata& metadata) {
+  content::RenderFrameHost* render_frame_host =

[Bryan McQuade, 2017/05/07 19:48:13]

can we DCHECK that the mojofication feature is enabled here? and likewise,
dcheck that it's not enabled when the IPC codepath is hit? that probably means
adding an extra method besides OnTimingUpdated so you have an IPC-specific
method to dcheck in.

[lpy, 2017/05/08 18:38:33]

Done.

+      page_load_metrics_binding_.GetCurrentTargetFrame();
+  OnTimingUpdated(render_frame_host, timing, metadata);
+}
+
 bool MetricsWebContentsObserver::ShouldTrackNavigation(
     content::NavigationHandle* navigation_handle) const {
   DCHECK(navigation_handle->IsInMainFrame());
   DCHECK(!navigation_handle->HasCommitted() ||
          !navigation_handle->IsSameDocument());
 
   return BrowserPageTrackDecider(embedder_interface_.get(), web_contents(),
                                  navigation_handle).ShouldTrack();
 }
 
@@ skipping 19 matching lines @@
     observer_->RemoveTestingObserver(this);
     observer_ = nullptr;
   }
 }
 
 void MetricsWebContentsObserver::TestingObserver::OnGoingAway() {
   observer_ = nullptr;
 }
 
 }  // namespace page_load_metrics