chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc - Issue 2823523003: [Page Load Metrics] PageLoadMetrics Mojofication.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc

Issue 2823523003: [Page Load Metrics] PageLoadMetrics Mojofication. (Closed)

Patch Set: Update Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc ('K') | « chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc ('k') | chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc » ('j') | chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc

diff --git a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc

index ac8a004ccd3304f38f952e58057366f9c8b0e6de..c44d7e9824d9387fee1f9e5286e7400e20e14ba4 100644

--- a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc

+++ b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc

@@ -700,7 +700,7 @@ TEST_F(CorePageLoadMetricsObserverTest, FirstMeaningfulPaintAfterInteraction) {

SimulateInputEvent(mouse_event);

timing.paint_timing.first_meaningful_paint =

- base::TimeDelta::FromMilliseconds(1000);

+ base::TimeDelta::FromMilliseconds(1100);

Zhen Wang 2017/04/19 21:52:47 Is there any reason to change this?

lpy 2017/04/20 01:49:24 The overhead of SimulateTimingUpdate increases a l

PopulateRequiredTimingFields(&timing);

SimulateTimingUpdate(timing);