Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Side by Side Diff: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc

Issue 2823523003: [Page Load Metrics] PageLoadMetrics Mojofication. (Closed)
Patch Set: Update Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/page_load_metrics/observers/core_page_load_metrics_obse rver.h" 5 #include "chrome/browser/page_load_metrics/observers/core_page_load_metrics_obse rver.h"
6 6
7 #include "base/memory/ptr_util.h" 7 #include "base/memory/ptr_util.h"
8 #include "chrome/browser/page_load_metrics/observers/page_load_metrics_observer_ test_harness.h" 8 #include "chrome/browser/page_load_metrics/observers/page_load_metrics_observer_ test_harness.h"
9 #include "chrome/browser/page_load_metrics/page_load_metrics_util.h" 9 #include "chrome/browser/page_load_metrics/page_load_metrics_util.h"
10 #include "chrome/test/base/testing_browser_process.h" 10 #include "chrome/test/base/testing_browser_process.h"
(...skipping 682 matching lines...) Expand 10 before | Expand all | Expand 10 after
693 693
694 NavigateAndCommit(GURL(kDefaultTestUrl)); 694 NavigateAndCommit(GURL(kDefaultTestUrl));
695 SimulateTimingUpdate(timing); 695 SimulateTimingUpdate(timing);
696 696
697 blink::WebMouseEvent mouse_event(blink::WebInputEvent::kMouseDown, 697 blink::WebMouseEvent mouse_event(blink::WebInputEvent::kMouseDown,
698 blink::WebInputEvent::kNoModifiers, 698 blink::WebInputEvent::kNoModifiers,
699 blink::WebInputEvent::kTimeStampForTesting); 699 blink::WebInputEvent::kTimeStampForTesting);
700 SimulateInputEvent(mouse_event); 700 SimulateInputEvent(mouse_event);
701 701
702 timing.paint_timing.first_meaningful_paint = 702 timing.paint_timing.first_meaningful_paint =
703 base::TimeDelta::FromMilliseconds(1000); 703 base::TimeDelta::FromMilliseconds(1100);
Zhen Wang 2017/04/19 21:52:47 Is there any reason to change this?
lpy 2017/04/20 01:49:24 The overhead of SimulateTimingUpdate increases a l
704 PopulateRequiredTimingFields(&timing); 704 PopulateRequiredTimingFields(&timing);
705 SimulateTimingUpdate(timing); 705 SimulateTimingUpdate(timing);
706 706
707 NavigateAndCommit(GURL(kDefaultTestUrl2)); 707 NavigateAndCommit(GURL(kDefaultTestUrl2));
708 708
709 histogram_tester().ExpectTotalCount( 709 histogram_tester().ExpectTotalCount(
710 internal::kHistogramFirstMeaningfulPaint, 0); 710 internal::kHistogramFirstMeaningfulPaint, 0);
711 histogram_tester().ExpectTotalCount( 711 histogram_tester().ExpectTotalCount(
712 internal::kHistogramParseStartToFirstMeaningfulPaint, 0); 712 internal::kHistogramParseStartToFirstMeaningfulPaint, 0);
713 histogram_tester().ExpectBucketCount( 713 histogram_tester().ExpectBucketCount(
714 internal::kHistogramFirstMeaningfulPaintStatus, 714 internal::kHistogramFirstMeaningfulPaintStatus,
715 internal::FIRST_MEANINGFUL_PAINT_USER_INTERACTION_BEFORE_FMP, 1); 715 internal::FIRST_MEANINGFUL_PAINT_USER_INTERACTION_BEFORE_FMP, 1);
716 } 716 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698