Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Side by Side Diff: chrome/renderer/page_load_metrics/page_timing_metrics_sender.h

Issue 2823523003: [Page Load Metrics] PageLoadMetrics Mojofication. (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_RENDERER_PAGE_LOAD_METRICS_PAGE_TIMING_METRICS_SENDER_H_ 5 #ifndef CHROME_RENDERER_PAGE_LOAD_METRICS_PAGE_TIMING_METRICS_SENDER_H_
6 #define CHROME_RENDERER_PAGE_LOAD_METRICS_PAGE_TIMING_METRICS_SENDER_H_ 6 #define CHROME_RENDERER_PAGE_LOAD_METRICS_PAGE_TIMING_METRICS_SENDER_H_
7 7
8 #include <memory> 8 #include <memory>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
11 #include "chrome/common/page_load_metrics/page_load_timing.h" 11 #include "chrome/common/page_load_metrics/page_load_timing.h"
12 #include "third_party/WebKit/public/platform/WebLoadingBehaviorFlag.h" 12 #include "third_party/WebKit/public/platform/WebLoadingBehaviorFlag.h"
13 13
14 namespace base { 14 namespace base {
15 class Timer; 15 class Timer;
16 } // namespace base 16 } // namespace base
17 17
18 namespace IPC { 18 namespace page_load_metrics {
19 class Sender;
20 } // namespace IPC
21 19
22 namespace page_load_metrics { 20 class PageTimingSender;
23 21
24 // PageTimingMetricsSender is responsible for sending page load timing metrics 22 // PageTimingMetricsSender is responsible for sending page load timing metrics
25 // over IPC. PageTimingMetricsSender may coalesce sent IPCs in order to 23 // over IPC. PageTimingMetricsSender may coalesce sent IPCs in order to
26 // minimize IPC contention. 24 // minimize IPC contention.
27 class PageTimingMetricsSender { 25 class PageTimingMetricsSender {
28 public: 26 public:
29 PageTimingMetricsSender(IPC::Sender* ipc_sender, 27 PageTimingMetricsSender(std::unique_ptr<PageTimingSender> sender,
30 int routing_id,
31 std::unique_ptr<base::Timer> timer, 28 std::unique_ptr<base::Timer> timer,
32 mojom::PageLoadTimingPtr initial_timing); 29 mojom::PageLoadTimingPtr initial_timing);
33 ~PageTimingMetricsSender(); 30 ~PageTimingMetricsSender();
34 31
35 void DidObserveLoadingBehavior(blink::WebLoadingBehaviorFlag behavior); 32 void DidObserveLoadingBehavior(blink::WebLoadingBehaviorFlag behavior);
36 void Send(mojom::PageLoadTimingPtr timing); 33 void Send(mojom::PageLoadTimingPtr timing);
37 34
38 protected: 35 protected:
39 base::Timer* timer() const { return timer_.get(); } 36 base::Timer* timer() const { return timer_.get(); }
40 37
41 private: 38 private:
42 void EnsureSendTimer(); 39 void EnsureSendTimer();
43 void SendNow(); 40 void SendNow();
44 41
45 IPC::Sender* const ipc_sender_; 42 std::unique_ptr<PageTimingSender> sender_;
46 const int routing_id_;
47 std::unique_ptr<base::Timer> timer_; 43 std::unique_ptr<base::Timer> timer_;
48 mojom::PageLoadTimingPtr last_timing_; 44 mojom::PageLoadTimingPtr last_timing_;
49 45
50 // The the sender keep track of metadata as it comes in, because the sender is 46 // The the sender keep track of metadata as it comes in, because the sender is
51 // scoped to a single committed load. 47 // scoped to a single committed load.
52 mojom::PageLoadMetadata metadata_; 48 mojom::PageLoadMetadataPtr metadata_;
53 49
54 bool have_sent_ipc_ = false; 50 bool have_sent_ipc_ = false;
55 51
56 DISALLOW_COPY_AND_ASSIGN(PageTimingMetricsSender); 52 DISALLOW_COPY_AND_ASSIGN(PageTimingMetricsSender);
57 }; 53 };
58 54
59 } // namespace page_load_metrics 55 } // namespace page_load_metrics
60 56
61 #endif // CHROME_RENDERER_PAGE_LOAD_METRICS_PAGE_TIMING_METRICS_SENDER_H_ 57 #endif // CHROME_RENDERER_PAGE_LOAD_METRICS_PAGE_TIMING_METRICS_SENDER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698