Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Side by Side Diff: chrome/renderer/page_load_metrics/page_timing_metrics_sender.cc

Issue 2823523003: [Page Load Metrics] PageLoadMetrics Mojofication. (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/renderer/page_load_metrics/page_timing_metrics_sender.h" 5 #include "chrome/renderer/page_load_metrics/page_timing_metrics_sender.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/callback.h" 9 #include "base/callback.h"
10 #include "base/time/time.h" 10 #include "base/time/time.h"
11 #include "base/timer/timer.h" 11 #include "base/timer/timer.h"
12 #include "chrome/common/page_load_metrics/page_load_metrics_messages.h" 12 #include "chrome/renderer/page_load_metrics/page_timing_sender.h"
13 #include "ipc/ipc_sender.h"
14 13
15 namespace page_load_metrics { 14 namespace page_load_metrics {
16 15
17 namespace { 16 namespace {
18 const int kInitialTimerDelayMillis = 50; 17 const int kInitialTimerDelayMillis = 50;
19 const int kTimerDelayMillis = 1000; 18 const int kTimerDelayMillis = 1000;
20 } // namespace 19 } // namespace
21 20
22 PageTimingMetricsSender::PageTimingMetricsSender( 21 PageTimingMetricsSender::PageTimingMetricsSender(
23 IPC::Sender* ipc_sender, 22 std::unique_ptr<PageTimingSender> sender,
24 int routing_id,
25 std::unique_ptr<base::Timer> timer, 23 std::unique_ptr<base::Timer> timer,
26 mojom::PageLoadTimingPtr initial_timing) 24 mojom::PageLoadTimingPtr initial_timing)
27 : ipc_sender_(ipc_sender), 25 : sender_(std::move(sender)),
28 routing_id_(routing_id),
29 timer_(std::move(timer)), 26 timer_(std::move(timer)),
30 last_timing_(std::move(initial_timing)), 27 last_timing_(std::move(initial_timing)),
31 metadata_(mojom::PageLoadMetadata()) { 28 metadata_(mojom::PageLoadMetadata::New()) {
32 if (!IsEmpty(*last_timing_)) { 29 if (!IsEmpty(*last_timing_)) {
33 EnsureSendTimer(); 30 EnsureSendTimer();
34 } 31 }
35 } 32 }
36 33
37 // On destruction, we want to send any data we have if we have a timer 34 // On destruction, we want to send any data we have if we have a timer
38 // currently running (and thus are talking to a browser process) 35 // currently running (and thus are talking to a browser process)
39 PageTimingMetricsSender::~PageTimingMetricsSender() { 36 PageTimingMetricsSender::~PageTimingMetricsSender() {
40 if (timer_->IsRunning()) { 37 if (timer_->IsRunning()) {
41 timer_->Stop(); 38 timer_->Stop();
42 SendNow(); 39 SendNow();
43 } 40 }
44 } 41 }
45 42
46 void PageTimingMetricsSender::DidObserveLoadingBehavior( 43 void PageTimingMetricsSender::DidObserveLoadingBehavior(
47 blink::WebLoadingBehaviorFlag behavior) { 44 blink::WebLoadingBehaviorFlag behavior) {
48 if (behavior & metadata_.behavior_flags) 45 if (behavior & metadata_->behavior_flags)
49 return; 46 return;
50 metadata_.behavior_flags |= behavior; 47 metadata_->behavior_flags |= behavior;
51 EnsureSendTimer(); 48 EnsureSendTimer();
52 } 49 }
53 50
54 void PageTimingMetricsSender::Send(mojom::PageLoadTimingPtr timing) { 51 void PageTimingMetricsSender::Send(mojom::PageLoadTimingPtr timing) {
55 if (last_timing_->Equals(*timing)) 52 if (last_timing_->Equals(*timing))
56 return; 53 return;
57 54
58 // We want to make sure that each PageTimingMetricsSender is associated 55 // We want to make sure that each PageTimingMetricsSender is associated
59 // with a distinct page navigation. Because we reset the object on commit, 56 // with a distinct page navigation. Because we reset the object on commit,
60 // we can trash last_timing_ on a provisional load before SendNow() fires. 57 // we can trash last_timing_ on a provisional load before SendNow() fires.
(...skipping 13 matching lines...) Expand all
74 int delay_ms = 71 int delay_ms =
75 have_sent_ipc_ ? kTimerDelayMillis : kInitialTimerDelayMillis; 72 have_sent_ipc_ ? kTimerDelayMillis : kInitialTimerDelayMillis;
76 timer_->Start( 73 timer_->Start(
77 FROM_HERE, base::TimeDelta::FromMilliseconds(delay_ms), 74 FROM_HERE, base::TimeDelta::FromMilliseconds(delay_ms),
78 base::Bind(&PageTimingMetricsSender::SendNow, base::Unretained(this))); 75 base::Bind(&PageTimingMetricsSender::SendNow, base::Unretained(this)));
79 } 76 }
80 } 77 }
81 78
82 void PageTimingMetricsSender::SendNow() { 79 void PageTimingMetricsSender::SendNow() {
83 have_sent_ipc_ = true; 80 have_sent_ipc_ = true;
84 ipc_sender_->Send(new PageLoadMetricsMsg_TimingUpdated( 81 sender_->SendTiming(last_timing_, metadata_);
85 routing_id_, *last_timing_, metadata_));
86 } 82 }
87 83
88 } // namespace page_load_metrics 84 } // namespace page_load_metrics
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698