OLD | NEW |
---|---|
1 // Copyright 2015 The Chromium Authors. All rights reserved. | 1 // Copyright 2015 The Chromium Authors. All rights reserved. |
2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
4 | 4 |
5 #include "chrome/renderer/page_load_metrics/page_timing_metrics_sender.h" | 5 #include "chrome/renderer/page_load_metrics/page_timing_metrics_sender.h" |
6 | 6 |
7 #include "base/time/time.h" | 7 #include "base/time/time.h" |
8 #include "base/timer/mock_timer.h" | 8 #include "base/timer/mock_timer.h" |
9 #include "chrome/common/page_load_metrics/page_load_timing.h" | 9 #include "chrome/common/page_load_metrics/page_load_metrics.mojom.h" |
10 #include "chrome/renderer/page_load_metrics/fake_page_timing_metrics_ipc_sender. h" | 10 #include "chrome/renderer/page_load_metrics/fake_page_timing_sender.h" |
11 #include "ipc/ipc_message.h" | |
12 #include "testing/gtest/include/gtest/gtest.h" | 11 #include "testing/gtest/include/gtest/gtest.h" |
13 | 12 |
14 namespace page_load_metrics { | 13 namespace page_load_metrics { |
15 | 14 |
16 // Thin wrapper around PageTimingMetricsSender that provides access to the | 15 // Thin wrapper around PageTimingMetricsSender that provides access to the |
17 // MockTimer instance. | 16 // MockTimer instance. |
18 class TestPageTimingMetricsSender : public PageTimingMetricsSender { | 17 class TestPageTimingMetricsSender : public PageTimingMetricsSender { |
19 public: | 18 public: |
20 explicit TestPageTimingMetricsSender(IPC::Sender* ipc_sender, | 19 explicit TestPageTimingMetricsSender( |
21 mojom::PageLoadTimingPtr initial_timing) | 20 std::unique_ptr<PageTimingSender> page_timing_sender, |
21 mojom::PageLoadTimingPtr initial_timing) | |
22 : PageTimingMetricsSender( | 22 : PageTimingMetricsSender( |
23 ipc_sender, | 23 std::move(page_timing_sender), |
24 MSG_ROUTING_NONE, | |
25 std::unique_ptr<base::Timer>(new base::MockTimer(false, false)), | 24 std::unique_ptr<base::Timer>(new base::MockTimer(false, false)), |
26 std::move(initial_timing)) {} | 25 std::move(initial_timing)) {} |
27 | 26 |
28 base::MockTimer* mock_timer() const { | 27 base::MockTimer* mock_timer() const { |
29 return reinterpret_cast<base::MockTimer*>(timer()); | 28 return reinterpret_cast<base::MockTimer*>(timer()); |
30 } | 29 } |
31 }; | 30 }; |
32 | 31 |
33 class PageTimingMetricsSenderTest : public testing::Test { | 32 class PageTimingMetricsSenderTest : public testing::Test { |
34 public: | 33 public: |
35 PageTimingMetricsSenderTest() | 34 PageTimingMetricsSenderTest() |
36 : metrics_sender_( | 35 : metrics_sender_(new TestPageTimingMetricsSender( |
37 new TestPageTimingMetricsSender(&fake_ipc_sender_, | 36 base::WrapUnique<PageTimingSender>( |
Bryan McQuade
2017/05/19 14:06:18
nit: we should use base::MakeUnique here instead.
lpy
2017/05/19 23:52:38
Done.
| |
38 mojom::PageLoadTiming::New())) {} | 37 new FakePageTimingSender(&validator_)), |
38 mojom::PageLoadTiming::New())) {} | |
39 | 39 |
40 protected: | 40 protected: |
41 FakePageTimingMetricsIPCSender fake_ipc_sender_; | 41 FakePageTimingSender::PageTimingValidator validator_; |
42 std::unique_ptr<TestPageTimingMetricsSender> metrics_sender_; | 42 std::unique_ptr<TestPageTimingMetricsSender> metrics_sender_; |
43 }; | 43 }; |
44 | 44 |
45 TEST_F(PageTimingMetricsSenderTest, Basic) { | 45 TEST_F(PageTimingMetricsSenderTest, Basic) { |
46 base::Time nav_start = base::Time::FromDoubleT(10); | 46 base::Time nav_start = base::Time::FromDoubleT(10); |
47 base::TimeDelta first_layout = base::TimeDelta::FromMillisecondsD(2); | 47 base::TimeDelta first_layout = base::TimeDelta::FromMillisecondsD(2); |
48 | 48 |
49 mojom::PageLoadTiming timing; | 49 mojom::PageLoadTiming timing; |
50 page_load_metrics::InitPageLoadTimingForTest(&timing); | 50 InitPageLoadTimingForTest(&timing); |
51 timing.navigation_start = nav_start; | 51 timing.navigation_start = nav_start; |
52 timing.document_timing->first_layout = first_layout; | 52 timing.document_timing->first_layout = first_layout; |
53 | 53 |
54 metrics_sender_->Send(timing.Clone()); | 54 metrics_sender_->Send(timing.Clone()); |
55 | 55 |
56 // Firing the timer should trigger sending of an OnTimingUpdated IPC. | 56 // Firing the timer should trigger sending of an SendTiming call. |
57 fake_ipc_sender_.ExpectPageLoadTiming(timing); | 57 validator_.ExpectPageLoadTiming(timing); |
58 ASSERT_TRUE(metrics_sender_->mock_timer()->IsRunning()); | 58 ASSERT_TRUE(metrics_sender_->mock_timer()->IsRunning()); |
59 metrics_sender_->mock_timer()->Fire(); | 59 metrics_sender_->mock_timer()->Fire(); |
60 EXPECT_FALSE(metrics_sender_->mock_timer()->IsRunning()); | 60 EXPECT_FALSE(metrics_sender_->mock_timer()->IsRunning()); |
61 | 61 |
62 // At this point, we should have triggered the send of the PageLoadTiming IPC. | 62 // At this point, we should have triggered the send of the SendTiming call. |
63 fake_ipc_sender_.VerifyExpectedTimings(); | 63 validator_.VerifyExpectedTimings(); |
64 | 64 |
65 // Attempt to send the same timing instance again. The send should be | 65 // Attempt to send the same timing instance again. The send should be |
66 // suppressed, since the timing instance hasn't changed since the last send. | 66 // suppressed, since the timing instance hasn't changed since the last send. |
67 metrics_sender_->Send(timing.Clone()); | 67 metrics_sender_->Send(timing.Clone()); |
68 EXPECT_FALSE(metrics_sender_->mock_timer()->IsRunning()); | 68 EXPECT_FALSE(metrics_sender_->mock_timer()->IsRunning()); |
69 } | 69 } |
70 | 70 |
71 TEST_F(PageTimingMetricsSenderTest, CoalesceMultipleIPCs) { | 71 TEST_F(PageTimingMetricsSenderTest, CoalesceMultipleTimings) { |
72 base::Time nav_start = base::Time::FromDoubleT(10); | 72 base::Time nav_start = base::Time::FromDoubleT(10); |
73 base::TimeDelta first_layout = base::TimeDelta::FromMillisecondsD(2); | 73 base::TimeDelta first_layout = base::TimeDelta::FromMillisecondsD(2); |
74 base::TimeDelta load_event = base::TimeDelta::FromMillisecondsD(4); | 74 base::TimeDelta load_event = base::TimeDelta::FromMillisecondsD(4); |
75 | 75 |
76 mojom::PageLoadTiming timing; | 76 mojom::PageLoadTiming timing; |
77 page_load_metrics::InitPageLoadTimingForTest(&timing); | 77 InitPageLoadTimingForTest(&timing); |
78 timing.navigation_start = nav_start; | 78 timing.navigation_start = nav_start; |
79 timing.document_timing->first_layout = first_layout; | 79 timing.document_timing->first_layout = first_layout; |
80 | 80 |
81 metrics_sender_->Send(timing.Clone()); | 81 metrics_sender_->Send(timing.Clone()); |
82 ASSERT_TRUE(metrics_sender_->mock_timer()->IsRunning()); | 82 ASSERT_TRUE(metrics_sender_->mock_timer()->IsRunning()); |
83 | 83 |
84 // Send an updated PageLoadTiming before the timer has fired. When the timer | 84 // Send an updated PageLoadTiming before the timer has fired. When the timer |
85 // fires, the updated PageLoadTiming should be sent. | 85 // fires, the updated PageLoadTiming should be sent. |
86 timing.document_timing->load_event_start = load_event; | 86 timing.document_timing->load_event_start = load_event; |
87 metrics_sender_->Send(timing.Clone()); | 87 metrics_sender_->Send(timing.Clone()); |
88 | 88 |
89 // Firing the timer should trigger sending of the OnTimingUpdated IPC with | 89 // Firing the timer should trigger sending of the SendTiming call with |
90 // the most recently provided PageLoadTiming instance. | 90 // the most recently provided PageLoadTiming instance. |
91 fake_ipc_sender_.ExpectPageLoadTiming(timing); | 91 validator_.ExpectPageLoadTiming(timing); |
92 metrics_sender_->mock_timer()->Fire(); | 92 metrics_sender_->mock_timer()->Fire(); |
93 EXPECT_FALSE(metrics_sender_->mock_timer()->IsRunning()); | 93 EXPECT_FALSE(metrics_sender_->mock_timer()->IsRunning()); |
94 } | 94 } |
95 | 95 |
96 TEST_F(PageTimingMetricsSenderTest, MultipleIPCs) { | 96 TEST_F(PageTimingMetricsSenderTest, MultipleTimings) { |
97 base::Time nav_start = base::Time::FromDoubleT(10); | 97 base::Time nav_start = base::Time::FromDoubleT(10); |
98 base::TimeDelta first_layout = base::TimeDelta::FromMillisecondsD(2); | 98 base::TimeDelta first_layout = base::TimeDelta::FromMillisecondsD(2); |
99 base::TimeDelta load_event = base::TimeDelta::FromMillisecondsD(4); | 99 base::TimeDelta load_event = base::TimeDelta::FromMillisecondsD(4); |
100 | 100 |
101 mojom::PageLoadTiming timing; | 101 mojom::PageLoadTiming timing; |
102 page_load_metrics::InitPageLoadTimingForTest(&timing); | 102 InitPageLoadTimingForTest(&timing); |
103 timing.navigation_start = nav_start; | 103 timing.navigation_start = nav_start; |
104 timing.document_timing->first_layout = first_layout; | 104 timing.document_timing->first_layout = first_layout; |
105 | 105 |
106 metrics_sender_->Send(timing.Clone()); | 106 metrics_sender_->Send(timing.Clone()); |
107 ASSERT_TRUE(metrics_sender_->mock_timer()->IsRunning()); | 107 ASSERT_TRUE(metrics_sender_->mock_timer()->IsRunning()); |
108 fake_ipc_sender_.ExpectPageLoadTiming(timing); | 108 validator_.ExpectPageLoadTiming(timing); |
109 metrics_sender_->mock_timer()->Fire(); | 109 metrics_sender_->mock_timer()->Fire(); |
110 EXPECT_FALSE(metrics_sender_->mock_timer()->IsRunning()); | 110 EXPECT_FALSE(metrics_sender_->mock_timer()->IsRunning()); |
111 fake_ipc_sender_.VerifyExpectedTimings(); | 111 validator_.VerifyExpectedTimings(); |
112 | 112 |
113 // Send an updated PageLoadTiming after the timer for the first send request | 113 // Send an updated PageLoadTiming after the timer for the first send request |
114 // has fired, and verify that a second IPC is sent. | 114 // has fired, and verify that a second timing is sent. |
115 timing.document_timing->load_event_start = load_event; | 115 timing.document_timing->load_event_start = load_event; |
116 metrics_sender_->Send(timing.Clone()); | 116 metrics_sender_->Send(timing.Clone()); |
117 ASSERT_TRUE(metrics_sender_->mock_timer()->IsRunning()); | 117 ASSERT_TRUE(metrics_sender_->mock_timer()->IsRunning()); |
118 fake_ipc_sender_.ExpectPageLoadTiming(timing); | 118 validator_.ExpectPageLoadTiming(timing); |
119 metrics_sender_->mock_timer()->Fire(); | 119 metrics_sender_->mock_timer()->Fire(); |
120 EXPECT_FALSE(metrics_sender_->mock_timer()->IsRunning()); | 120 EXPECT_FALSE(metrics_sender_->mock_timer()->IsRunning()); |
121 } | 121 } |
122 | 122 |
123 TEST_F(PageTimingMetricsSenderTest, SendIPCOnDestructor) { | 123 TEST_F(PageTimingMetricsSenderTest, SendTimingOnDestructor) { |
124 mojom::PageLoadTiming timing; | 124 mojom::PageLoadTiming timing; |
125 page_load_metrics::InitPageLoadTimingForTest(&timing); | 125 InitPageLoadTimingForTest(&timing); |
126 timing.navigation_start = base::Time::FromDoubleT(10); | 126 timing.navigation_start = base::Time::FromDoubleT(10); |
127 timing.document_timing->first_layout = base::TimeDelta::FromMilliseconds(10); | 127 timing.document_timing->first_layout = base::TimeDelta::FromMilliseconds(10); |
128 | 128 |
129 // This test wants to verify behavior in the PageTimingMetricsSender | 129 // This test wants to verify behavior in the PageTimingMetricsSender |
130 // destructor. The EXPECT_CALL will be satisfied when the |metrics_sender_| | 130 // destructor. The EXPECT_CALL will be satisfied when the |metrics_sender_| |
131 // is destroyed below. | 131 // is destroyed below. |
132 metrics_sender_->Send(timing.Clone()); | 132 metrics_sender_->Send(timing.Clone()); |
133 fake_ipc_sender_.ExpectPageLoadTiming(timing); | 133 validator_.ExpectPageLoadTiming(timing); |
134 ASSERT_TRUE(metrics_sender_->mock_timer()->IsRunning()); | 134 ASSERT_TRUE(metrics_sender_->mock_timer()->IsRunning()); |
135 | 135 |
136 // Destroy |metrics_sender_|, in order to force its destructor to run. | 136 // Destroy |metrics_sender_|, in order to force its destructor to run. |
137 metrics_sender_.reset(); | 137 metrics_sender_.reset(); |
138 } | 138 } |
139 | 139 |
140 } // namespace page_load_metrics | 140 } // namespace page_load_metrics |
OLD | NEW |