OLD | NEW |
---|---|
(Empty) | |
1 // Copyright 2017 The Chromium Authors. All rights reserved. | |
2 // Use of this source code is governed by a BSD-style license that can be | |
3 // found in the LICENSE file. | |
4 | |
5 #include "chrome/renderer/page_load_metrics/page_timing_sender.h" | |
6 | |
7 #include "base/feature_list.h" | |
8 #include "base/memory/ptr_util.h" | |
9 #include "chrome/common/chrome_features.h" | |
10 #include "chrome/common/page_load_metrics/page_load_metrics.mojom.h" | |
11 #include "chrome/common/page_load_metrics/page_load_metrics_messages.h" | |
12 #include "content/public/common/associated_interface_provider.h" | |
13 #include "content/public/renderer/render_frame.h" | |
14 #include "ipc/ipc_sender.h" | |
15 | |
16 namespace page_load_metrics { | |
17 | |
18 class LegacyIPCPageTimingSender : public IPC::Sender, public PageTimingSender { | |
Bryan McQuade
2017/05/19 14:06:18
does this need to implement IPC::Sender anymore? s
lpy
2017/05/19 23:52:38
Done.
| |
19 public: | |
20 LegacyIPCPageTimingSender(content::RenderFrame* render_frame, | |
21 const int routing_id) | |
22 : render_frame_(render_frame), routing_id_(routing_id) {} | |
Bryan McQuade
2017/05/19 14:06:18
can the render frame ever be null? iirc we had som
lpy
2017/05/19 23:52:38
Done.
| |
23 ~LegacyIPCPageTimingSender() override {} | |
24 | |
25 void SendTiming(const mojom::PageLoadTimingPtr& timing, | |
26 const mojom::PageLoadMetadataPtr& metadata) override { | |
27 Send(new PageLoadMetricsMsg_TimingUpdated(routing_id_, *timing, *metadata)); | |
28 } | |
29 | |
30 private: | |
31 // IPC::Sender implementation. | |
32 bool Send(IPC::Message* message) override { | |
Bryan McQuade
2017/05/19 14:06:18
let's inline this up into SendTiming() above
lpy
2017/05/19 23:52:38
Done.
| |
33 if (render_frame_) | |
34 return render_frame_->Send(message); | |
35 delete message; | |
Bryan McQuade
2017/05/19 14:06:19
do we want to delete here? I was under the impress
lpy
2017/05/19 23:52:38
https://cs.chromium.org/chromium/src/content/publi
| |
36 return false; | |
37 } | |
38 | |
39 content::RenderFrame* render_frame_ = nullptr; | |
40 const int routing_id_; | |
41 }; | |
42 | |
43 class MojoIPCPageTimingSender : public PageTimingSender { | |
44 public: | |
45 explicit MojoIPCPageTimingSender(content::RenderFrame* render_frame) | |
46 : render_frame_(render_frame) {} | |
47 ~MojoIPCPageTimingSender() override {} | |
48 void SendTiming(const mojom::PageLoadTimingPtr& timing, | |
49 const mojom::PageLoadMetadataPtr& metadata) override { | |
50 DCHECK(render_frame_ && render_frame_->GetWebFrame()); | |
51 if (!page_load_metrics_) { | |
Bryan McQuade
2017/05/19 14:06:18
I'd rather initialize this in the constructor (ins
lpy
2017/05/19 23:52:38
Done.
| |
52 render_frame_->GetRemoteAssociatedInterfaces()->GetInterface( | |
53 &page_load_metrics_); | |
54 } | |
55 page_load_metrics_->UpdateTiming(timing->Clone(), metadata->Clone()); | |
56 } | |
57 | |
58 private: | |
59 content::RenderFrame* const render_frame_; | |
60 // Use associated interface to make sure mojo messages are ordered with regard | |
61 // to legacy IPC messages. | |
62 mojom::PageLoadMetricsAssociatedPtr page_load_metrics_; | |
63 }; | |
64 | |
65 // static | |
66 std::unique_ptr<PageTimingSender> PageTimingSender::CreatePageTimingSender( | |
67 content::RenderFrame* render_frame, | |
68 const int routing_id) { | |
69 if (base::FeatureList::IsEnabled(features::kPageLoadMetricsMojofication)) { | |
70 return base::WrapUnique<PageTimingSender>( | |
71 new MojoIPCPageTimingSender(render_frame)); | |
72 } | |
73 return base::WrapUnique<PageTimingSender>( | |
74 new LegacyIPCPageTimingSender(render_frame, routing_id)); | |
75 } | |
76 | |
77 } // namespace page_load_metrics | |
OLD | NEW |