Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 2823503002: Only generate GPU json data entries related to a given platform at build time. (Closed)

Created:
3 years, 8 months ago by Zhenyao Mo
Modified:
3 years, 8 months ago
CC:
chromium-reviews, piman+watch_chromium.org, brettw, capn, sugoi1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Only generate GPU json data entries related to a given platform at build time. This is for SoftwareRenderingList and GpuDriverBugList. BUG=691703 TEST=chrome R=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2823503002 Cr-Commit-Position: refs/heads/master@{#464840} Committed: https://chromium.googlesource.com/chromium/src/+/a3071ce2bd0a82923d33a73a5c0c46408b837a14

Patch Set 1 #

Patch Set 2 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -20 lines) Patch
M gpu/config/BUILD.gn View 1 chunk +12 lines, -0 lines 0 comments Download
M gpu/config/gpu_driver_bug_list.json View 1 1 chunk +1 line, -2 lines 0 comments Download
M gpu/config/gpu_driver_bug_list_unittest.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M gpu/config/process_json.py View 9 chunks +26 lines, -16 lines 0 comments Download
M gpu/config/software_rendering_list.json View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
Zhenyao Mo
kbr: PTAL brettw: FYI (feel free to review) I verified the generated files on Linux ...
3 years, 8 months ago (2017-04-13 21:48:28 UTC) #9
Ken Russell (switch to Gerrit)
LGTM capn, sugoi: this is another reason not to refer to real entries in the ...
3 years, 8 months ago (2017-04-14 22:24:28 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2823503002/40001
3 years, 8 months ago (2017-04-14 22:31:29 UTC) #14
commit-bot: I haz the power
3 years, 8 months ago (2017-04-15 00:51:23 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/a3071ce2bd0a82923d33a73a5c0c...

Powered by Google App Engine
This is Rietveld 408576698