Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 2823483002: Make ModuleScript to have a reference to Modulator explicitly (Closed)

Created:
3 years, 8 months ago by hiroshige
Modified:
3 years, 8 months ago
Reviewers:
kouhei (in TOK)
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make ModuleScript to have a reference to Modulator explicitly This is to ensure the Modulator supplied when ModuleScript is created is also used throughout its lifetime, especially when it is executed in https://codereview.chromium.org/2819733002. BUG=594639 Review-Url: https://codereview.chromium.org/2823483002 Cr-Commit-Position: refs/heads/master@{#464827} Committed: https://chromium.googlesource.com/chromium/src/+/755670d02cf3c0bfbfdedcaaf7a34d67accaea93

Patch Set 1 #

Patch Set 2 : unit tests fix #

Messages

Total messages: 12 (8 generated)
kouhei (in TOK)
lgtm
3 years, 8 months ago (2017-04-14 03:20:11 UTC) #5
commit-bot: I haz the power
This CL has an open dependency (Issue 2817983002 Patch 1). Please resolve the dependency and ...
3 years, 8 months ago (2017-04-14 03:20:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2823483002/20001
3 years, 8 months ago (2017-04-14 21:53:21 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-14 23:37:44 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/755670d02cf3c0bfbfdedcaaf7a3...

Powered by Google App Engine
This is Rietveld 408576698