Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issue 2823413003: Fix wrong inclusion of .cc file in extensions/ (Closed)

Created:
3 years, 8 months ago by emaxx
Modified:
3 years, 8 months ago
Reviewers:
Finnur
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix wrong inclusion of .cc file in extensions/ BUG=713138 Review-Url: https://codereview.chromium.org/2823413003 Cr-Commit-Position: refs/heads/master@{#465600} Committed: https://chromium.googlesource.com/chromium/src/+/895210ec83415ea001f540529e81e55329497e50

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/extensions/extension_crash_recovery_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
emaxx
finnur@: PTAL.
3 years, 8 months ago (2017-04-19 12:22:54 UTC) #6
Finnur
LGTM
3 years, 8 months ago (2017-04-19 14:31:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2823413003/1
3 years, 8 months ago (2017-04-19 14:32:23 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 14:37:47 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/895210ec83415ea001f540529e81...

Powered by Google App Engine
This is Rietveld 408576698