Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Unified Diff: milo/appengine/frontend/templates/pages/build.html

Issue 2823413002: Milo buildbot: Add in the rest of the blame/commits information. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: milo/appengine/frontend/templates/pages/build.html
diff --git a/milo/appengine/frontend/templates/pages/build.html b/milo/appengine/frontend/templates/pages/build.html
index 50220185e3e5158f3ece88dc9e9616272fe0c876..c0cede2a1a4c548ea59de7034a0cde521ff50ed8 100644
--- a/milo/appengine/frontend/templates/pages/build.html
+++ b/milo/appengine/frontend/templates/pages/build.html
@@ -94,11 +94,11 @@
{{ end }}
{{ if .Commit.RequestRevision }}
- <tr><td class="left">Revision</td><td>{{ .Commit.RequestRevision }}</td></tr>
+ <tr><td class="left">Revision</td><td>{{ .Commit.RequestRevision | linkify }}</td></tr>
{{ end }}
{{ if .Commit.Revision }}
- <tr><td class="left">Got Revision</td><td>{{ .Commit.Revision }}</td></tr>
+ <tr><td class="left">Got Revision</td><td>{{ .Commit.Revision | linkify }}</td></tr>
{{ end }}
{{ if .Commit.Changelist }}
@@ -261,7 +261,48 @@
{{ range .Build.Blame }}
<li>
<h3>{{.Title}}</h3>
- <!--- TODO(hinoka): Layout the rest of this -->
+ <table class="info">
+ <tbody>
+ <tr>
+ <td class="left">Changed by</td>
+ <td><b>
nodir 2017/04/19 18:37:48 shouldn't we use CSS instead of <b> here and in fi
hinoka 2017/04/20 22:09:44 We could do that, <b> was because buildbot did it
+ {{ if .AuthorName }}{{ .AuthorName }} - {{ end }}
+ {{ .AuthorEmail | obfuscateEmail }}
+ </b></td>
+ </tr>
+ <tr>
+ <td class="left">Changed at</td>
+ <td><b>{{ .CommitTime | localTime "N/A" }}</b></td>
+ </tr>
+ <tr>
+ <td class="left">Repository</td>
+ <td><b>{{ .Repo }}</b></td>
+ </tr>
+ <tr>
+ <td class="left">Branch</td>
+ <td><b>{{ .Branch }}</b></td>
+ </tr>
+ <tr>
+ <td class="left">Revision</td>
+ <td><b>{{ .Revision | linkify }}</b></td>
+ </tr>
+ </tbody>
+ </table>
+
+ {{ if .Description }}
+ <h3>Comments</h3>
+ <pre class="comments">{{ .Description }}</pre>
+ {{ end }}
+
+ {{ if .File }}
+ <h3 class="files">Changed files</h3>
+ <ul class="alternating">
+ {{ range .File }}
+ <li><b>{{ . }}</b></li>
+ {{ end }}
+ </ul>
+ {{ end }}
+
</li>
{{ end }}
</ol>

Powered by Google App Engine
This is Rietveld 408576698