Web payment shipping address/option timeout.

Web payment shipping address/option timeout.

Before this patch, calling e.updateWith(new Promise((resolve) => {}));
would result in 'shippingoptionchange' and 'shippingaddresschange' never
timing out. This is because the timeout timer was being stopped in
updateWith() call.

The fix is to stop the timeout timer when the resolve() callback is
invoked instead of when updateWith() is called.

After this patch, calling e.updateWith(new Promise((resolve) => {}));
will timeout after 60 seconds.

To test manually:
1) Open https://rsolomakhin.github.io/pr/ko/promise/.
2) Click [Buy].
3) Change the shipping address or option.
Observe: The UI closes and the page shows an error message after 60
         seconds.

The error message has been made more verbose as well: "Timed out waiting
for a response to a 'shippingaddresschange' event".

BUG=711691
TEST=PaymentRequestUpdateEventTest

Review-Url: https://codereview.chromium.org/2823393002
Cr-Commit-Position: refs/heads/master@{#465698}
Committed: https://chromium.googlesource.com/chromium/src/+/34f37c9993ce9bff9a5561d03d6b9fa29fa48bff

[please use gerrit instead, 2017-04-18 20:16:11]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 20:16:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[please use gerrit instead, 2017-04-18 20:51:33]

rouslan@chromium.org changed reviewers:
+ mek@chromium.org

[please use gerrit instead, 2017-04-18 20:51:33]

Marijn, ptal.

[commit-bot: I haz the power, 2017-04-18 21:56:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 21:56:53]

Dry run: This issue passed the CQ dry run.

[Marijn Kruisselbrink, 2017-04-19 18:55:29]

lgtm

[please use gerrit instead, 2017-04-19 19:06:52]

The CQ bit was checked by rouslan@chromium.org

[commit-bot: I haz the power, 2017-04-19 19:07:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 19:14:32]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492628812858420, "parent_rev":
"58ee54b41b1703b1cb78d5d281611ed3629b8e78", "commit_rev":
"34f37c9993ce9bff9a5561d03d6b9fa29fa48bff"}

[commit-bot: I haz the power, 2017-04-19 19:14:46]

Description was changed from

==========
Web payment shipping address/option timeout.

Before this patch, calling e.updateWith(new Promise((resolve) => {}));
would result in 'shippingoptionchange' and 'shippingaddresschange' never
timing out. This is because the timeout timer was being stopped in
updateWith() call.

The fix is to stop the timeout timer when the resolve() callback is
invoked instead of when updateWith() is called.

After this patch, calling e.updateWith(new Promise((resolve) => {}));
will timeout after 60 seconds.

To test manually:
1) Open https://rsolomakhin.github.io/pr/ko/promise/.
2) Click [Buy].
3) Change the shipping address or option.
Observe: The UI closes and the page shows an error message after 60
         seconds.

The error message has been made more verbose as well: "Timed out waiting
for a response to a 'shippingaddresschange' event".

BUG=711691
TEST=PaymentRequestUpdateEventTest
==========

to

==========
Web payment shipping address/option timeout.

Before this patch, calling e.updateWith(new Promise((resolve) => {}));
would result in 'shippingoptionchange' and 'shippingaddresschange' never
timing out. This is because the timeout timer was being stopped in
updateWith() call.

The fix is to stop the timeout timer when the resolve() callback is
invoked instead of when updateWith() is called.

After this patch, calling e.updateWith(new Promise((resolve) => {}));
will timeout after 60 seconds.

To test manually:
1) Open https://rsolomakhin.github.io/pr/ko/promise/.
2) Click [Buy].
3) Change the shipping address or option.
Observe: The UI closes and the page shows an error message after 60
         seconds.

The error message has been made more verbose as well: "Timed out waiting
for a response to a 'shippingaddresschange' event".

BUG=711691
TEST=PaymentRequestUpdateEventTest

Review-Url: https://codereview.chromium.org/2823393002
Cr-Commit-Position: refs/heads/master@{#465698}
Committed:
https://chromium.googlesource.com/chromium/src/+/34f37c9993ce9bff9a5561d03d6b...
==========

[commit-bot: I haz the power, 2017-04-19 19:14:47]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/34f37c9993ce9bff9a5561d03d6b...