[js-perf-test] Add microbenchmarks for materialized rest parameters.

[js-perf-test] Add microbenchmarks for materialized rest parameters.

Functions that take mandatory parameters plus a number of optional
parameters, that need to be materialized as an Array are quite common.
The simplest possible case of this is essentially:

  function foo(mandatory, ...args) { return args; }

Babel translates this to something like:

  function foo(mandatory) {
    "use strict";
    for (var _len = arguments.length,
             args = Array(_len > 1 ? _len - 1 : 0),
             _key = 1; _key < _len; _key++) {
      args[_key - 1] = arguments[_key];
    }
    return args;
  }

The key to great performance here is to make sure that we don't
materialize the (unmapped) arguments object in this case, plus that we
have some kind of fast-path for the Array constructor and the
initialization loop.

This microbenchmark ensures that we have decent performance even in the
case where the assignment to args is polymorphic, i.e. the arguments
have seen different elements kinds, starting with FAST_HOLEY_ELEMENTS
and then FAST_HOLEY_SMI_ELEMENTS.

R=yangguo@chromium.org
BUG=v8:6262
Review-Url: https://codereview.chromium.org/2823343004
Cr-Commit-Position: refs/heads/master@{#44709}
Committed: https://chromium.googlesource.com/v8/v8/+/07e163bd5ac87cfb9539dfe3c2b0b1337e97985a

[Benedikt Meurer, 2017-04-19 04:55:43]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 04:55:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Benedikt Meurer, 2017-04-19 04:56:35]

Hey Yang,

Here's a js-perf-test for the materialized rest parameters case, both native and
transpiled. Please take a look.

Thanks,
Benedikt

[Yang, 2017-04-19 05:11:38]

lgtm

[Benedikt Meurer, 2017-04-19 05:11:50]

The CQ bit was unchecked by bmeurer@chromium.org

[Benedikt Meurer, 2017-04-19 05:11:56]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2017-04-19 05:12:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 05:25:40]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492578716244140, "parent_rev":
"c0ccdb5769c0a49fdc9dcefc922e044607500b2b", "commit_rev":
"07e163bd5ac87cfb9539dfe3c2b0b1337e97985a"}

[commit-bot: I haz the power, 2017-04-19 05:25:46]

Description was changed from

==========
[js-perf-test] Add microbenchmarks for materialized rest parameters.

Functions that take mandatory parameters plus a number of optional
parameters, that need to be materialized as an Array are quite common.
The simplest possible case of this is essentially:

  function foo(mandatory, ...args) { return args; }

Babel translates this to something like:

  function foo(mandatory) {
    "use strict";
    for (var _len = arguments.length,
             args = Array(_len > 1 ? _len - 1 : 0),
             _key = 1; _key < _len; _key++) {
      args[_key - 1] = arguments[_key];
    }
    return args;
  }

The key to great performance here is to make sure that we don't
materialize the (unmapped) arguments object in this case, plus that we
have some kind of fast-path for the Array constructor and the
initialization loop.

This microbenchmark ensures that we have decent performance even in the
case where the assignment to args is polymorphic, i.e. the arguments
have seen different elements kinds, starting with FAST_HOLEY_ELEMENTS
and then FAST_HOLEY_SMI_ELEMENTS.

R=yangguo@chromium.org
BUG=v8:6262
==========

to

==========
[js-perf-test] Add microbenchmarks for materialized rest parameters.

Functions that take mandatory parameters plus a number of optional
parameters, that need to be materialized as an Array are quite common.
The simplest possible case of this is essentially:

  function foo(mandatory, ...args) { return args; }

Babel translates this to something like:

  function foo(mandatory) {
    "use strict";
    for (var _len = arguments.length,
             args = Array(_len > 1 ? _len - 1 : 0),
             _key = 1; _key < _len; _key++) {
      args[_key - 1] = arguments[_key];
    }
    return args;
  }

The key to great performance here is to make sure that we don't
materialize the (unmapped) arguments object in this case, plus that we
have some kind of fast-path for the Array constructor and the
initialization loop.

This microbenchmark ensures that we have decent performance even in the
case where the assignment to args is polymorphic, i.e. the arguments
have seen different elements kinds, starting with FAST_HOLEY_ELEMENTS
and then FAST_HOLEY_SMI_ELEMENTS.

R=yangguo@chromium.org
BUG=v8:6262

Review-Url: https://codereview.chromium.org/2823343004
Cr-Commit-Position: refs/heads/master@{#44709}
Committed:
https://chromium.googlesource.com/v8/v8/+/07e163bd5ac87cfb9539dfe3c2b0b1337e9...
==========

[commit-bot: I haz the power, 2017-04-19 05:25:47]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/07e163bd5ac87cfb9539dfe3c2b0b1337e9...