Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 2823273003: Handle multiple textures per buffer in RTCVideoDecoder (Closed)

Created:
3 years, 8 months ago by emircan
Modified:
3 years, 8 months ago
Reviewers:
jbauman
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Handle multiple textures per buffer in RTCVideoDecoder This CL adds checks on RTCVideoDecoder so that it can handle formats with multiple textures per buffer, i.e. NV12 on Windows. BUG=712311 TEST=Tested AppRTC loopback with H264 on Windows. Added unittests. Review-Url: https://codereview.chromium.org/2823273003 Cr-Commit-Position: refs/heads/master@{#465352} Committed: https://chromium.googlesource.com/chromium/src/+/f1d77853394a703fc603f0ef0fae3cf6de9a1364

Patch Set 1 #

Patch Set 2 : Fix tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -34 lines) Patch
M content/renderer/media/gpu/rtc_video_decoder.h View 2 chunks +8 lines, -6 lines 0 comments Download
M content/renderer/media/gpu/rtc_video_decoder.cc View 9 chunks +40 lines, -28 lines 0 comments Download
M content/renderer/media/gpu/rtc_video_decoder_unittest.cc View 1 2 chunks +45 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (16 generated)
emircan
PTAL.
3 years, 8 months ago (2017-04-18 18:50:04 UTC) #5
jbauman
lgtm
3 years, 8 months ago (2017-04-18 19:15:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2823273003/20001
3 years, 8 months ago (2017-04-18 20:28:26 UTC) #17
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 20:34:00 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f1d77853394a703fc603f0ef0fae...

Powered by Google App Engine
This is Rietveld 408576698