Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2823273002:
chromeos: Adds ash_mus_unittests to the main waterfall (Closed)
Descriptionchromeos: Adds ash_mus_unittests to the main waterfall
The tests have been passing since yesterday.
BUG=705715
TEST=none
R=msw@chromium.org
Review-Url: https://codereview.chromium.org/2823273002
Cr-Commit-Position: refs/heads/master@{#465327}
Committed: https://chromium.googlesource.com/chromium/src/+/a53f68744f93a8b322d5b73ed028491dcdd9612e
Patch Set 1 #
Total comments: 3
Messages
Total messages: 14 (7 generated)
The CQ bit was checked by sky@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2823273002/diff/1/testing/buildbot/chromium.c... File testing/buildbot/chromium.chromiumos.json (right): https://codereview.chromium.org/2823273002/diff/1/testing/buildbot/chromium.c... testing/buildbot/chromium.chromiumos.json:50: "name": "ash_mus_unittests", Should we also be adding the same thing to "Linux ChromiumOS Tests (1)" and/or "Linux ChromiumOS Tests (dbg)(1)"?
https://codereview.chromium.org/2823273002/diff/1/testing/buildbot/chromium.c... File testing/buildbot/chromium.chromiumos.json (right): https://codereview.chromium.org/2823273002/diff/1/testing/buildbot/chromium.c... testing/buildbot/chromium.chromiumos.json:50: "name": "ash_mus_unittests", On 2017/04/18 18:35:04, msw wrote: > Should we also be adding the same thing to "Linux ChromiumOS Tests (1)" and/or > "Linux ChromiumOS Tests (dbg)(1)"? I added ash_mus_unittests to the same bots as mash_unittests. I suspect the bot you mention is x11, which this test won't work with (and we don't care about x11).
lgtm https://codereview.chromium.org/2823273002/diff/1/testing/buildbot/chromium.c... File testing/buildbot/chromium.chromiumos.json (right): https://codereview.chromium.org/2823273002/diff/1/testing/buildbot/chromium.c... testing/buildbot/chromium.chromiumos.json:50: "name": "ash_mus_unittests", On 2017/04/18 19:09:35, sky wrote: > On 2017/04/18 18:35:04, msw wrote: > > Should we also be adding the same thing to "Linux ChromiumOS Tests (1)" and/or > > "Linux ChromiumOS Tests (dbg)(1)"? > > I added ash_mus_unittests to the same bots as mash_unittests. I suspect the bot > you mention is x11, which this test won't work with (and we don't care about > x11). Hmm, presuming x11 and ozone are mutually exclusive, you're right that this bot's config includes ozone and the others do not.
671355 is against converting the bots to ozone only. It's part way there. On Tue, Apr 18, 2017 at 12:19 PM, <msw@chromium.org> wrote: > lgtm > > > > > https://codereview.chromium.org/2823273002/diff/1/testing/ > buildbot/chromium.chromiumos.json > File testing/buildbot/chromium.chromiumos.json (right): > > https://codereview.chromium.org/2823273002/diff/1/testing/ > buildbot/chromium.chromiumos.json#newcode50 > testing/buildbot/chromium.chromiumos.json:50: "name": > "ash_mus_unittests", > On 2017/04/18 19:09:35, sky wrote: > > On 2017/04/18 18:35:04, msw wrote: > > > Should we also be adding the same thing to "Linux ChromiumOS Tests > (1)" and/or > > > "Linux ChromiumOS Tests (dbg)(1)"? > > > > I added ash_mus_unittests to the same bots as mash_unittests. I > suspect the bot > > you mention is x11, which this test won't work with (and we don't care > about > > x11). > > Hmm, presuming x11 and ozone are mutually exclusive, you're right that > this bot's config includes ozone and the others do not. > > https://codereview.chromium.org/2823273002/ > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
The CQ bit was checked by sky@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1492543444298920, "parent_rev":
"19d7dde8fceec69335eec68e5d3a53b304f295f4", "commit_rev":
"a53f68744f93a8b322d5b73ed028491dcdd9612e"}
Message was sent while issue was closed.
Description was changed from ========== chromeos: Adds ash_mus_unittests to the main waterfall The tests have been passing since yesterday. BUG=705715 TEST=none R=msw@chromium.org ========== to ========== chromeos: Adds ash_mus_unittests to the main waterfall The tests have been passing since yesterday. BUG=705715 TEST=none R=msw@chromium.org Review-Url: https://codereview.chromium.org/2823273002 Cr-Commit-Position: refs/heads/master@{#465327} Committed: https://chromium.googlesource.com/chromium/src/+/a53f68744f93a8b322d5b73ed028... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/a53f68744f93a8b322d5b73ed028... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
