Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2823253002: Refactor decorators into thier own python class (Closed)

Created:
3 years, 8 months ago by Robert Ogden
Modified:
3 years, 8 months ago
Reviewers:
RyanSturm
CC:
chromium-reviews, posciak+watch_chromium.org, tbansal+watch-data-reduction-proxy_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor decorators into thier own python class BUG=712688 Review-Url: https://codereview.chromium.org/2823253002 Cr-Commit-Position: refs/heads/master@{#465291} Committed: https://chromium.googlesource.com/chromium/src/+/874291b7fb8a23a1cc97bce105bb40f60a9e3f4c

Patch Set 1 #

Patch Set 2 : Forgot to add new decorators class #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -77 lines) Patch
M tools/chrome_proxy/webdriver/common.py View 1 chunk +0 lines, -68 lines 0 comments Download
M tools/chrome_proxy/webdriver/compression_regression.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/chrome_proxy/webdriver/data_use.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/chrome_proxy/webdriver/decorator_smoke.py View 1 chunk +1 line, -1 line 0 comments Download
A tools/chrome_proxy/webdriver/decorators.py View 1 1 chunk +74 lines, -0 lines 0 comments Download
M tools/chrome_proxy/webdriver/quic.py View 1 chunk +2 lines, -0 lines 2 comments Download
M tools/chrome_proxy/webdriver/safebrowsing.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/chrome_proxy/webdriver/smoke.py View 3 chunks +3 lines, -3 lines 0 comments Download
M tools/chrome_proxy/webdriver/video.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
Robert Ogden
Ryan, please take a look :) It's just moving things around, no actual code changes.
3 years, 8 months ago (2017-04-18 15:35:09 UTC) #2
RyanSturm
Seems like a good change. lgtm with 1 question. https://codereview.chromium.org/2823253002/diff/20001/tools/chrome_proxy/webdriver/quic.py File tools/chrome_proxy/webdriver/quic.py (right): https://codereview.chromium.org/2823253002/diff/20001/tools/chrome_proxy/webdriver/quic.py#newcode5 tools/chrome_proxy/webdriver/quic.py:5: ...
3 years, 8 months ago (2017-04-18 17:34:05 UTC) #3
Robert Ogden
https://codereview.chromium.org/2823253002/diff/20001/tools/chrome_proxy/webdriver/quic.py File tools/chrome_proxy/webdriver/quic.py (right): https://codereview.chromium.org/2823253002/diff/20001/tools/chrome_proxy/webdriver/quic.py#newcode5 tools/chrome_proxy/webdriver/quic.py:5: import time On 2017/04/18 17:34:05, Ryan Sturm wrote: > ...
3 years, 8 months ago (2017-04-18 17:55:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2823253002/20001
3 years, 8 months ago (2017-04-18 17:56:21 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 18:11:47 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/874291b7fb8a23a1cc97bce105bb...

Powered by Google App Engine
This is Rietveld 408576698