DevTools: make JSFormatter aware of parenthesized expressions

DevTools: make JSFormatter aware of parenthesized expressions

JavascriptFormatter calls _beforeVisit() to collect tokens before visiting AST
nodes. However, the Acorn-provided AST did not generate enough info to
distinguish when the last ')' appeared, and our formatter would incorrectly add
a new line and indent whenever it saw any ')'.

This resulted in bad cases with expressions within more than one set of
parentheses (`if ((c))a;else b`).

This CL turns on an Acorn flag 'preserveParens' in order to distinguish and
insert a new line only for ')'s outside of a parenthesized expression.

Other examples:
with((c))a;
for (i=0; i< 5; (i++)){a;}
while ((true))x;

BUG=708493
Review-Url: https://codereview.chromium.org/2823233004
Cr-Commit-Position: refs/heads/master@{#465874}
Committed: https://chromium.googlesource.com/chromium/src/+/079dd5c40c3a59e588777c794a533f40755f8402

[luoe, 2017-04-18 23:05:02]

Description was changed from

==========
DevTools: make JSFormatter aware of parenthesized expressions

BUG=708493
==========

to

==========
DevTools: make JSFormatter aware of parenthesized expressions

JavascriptFormatter calls _beforeVisit() to collect tokens before visiting AST
nodes. However, the Acorn-provided AST did not generate enough info to
distinguish when the last ')' appeared, and our formatter would incorrectly add
a new line and indent whenever it saw any ')'.

This resulted in bad cases with expressions within more than one set of
parentheses (`if ((c))a;else b`).

This CL turns on an Acorn flag 'preserveParens' in order to distinguish and
insert a new line only for ')'s outside of a parenthesized expression.

Other examples:
with((c))a;
for (i=0; i< 5; (i++)){a;}
while ((true))x;

BUG=708493
==========

[luoe, 2017-04-18 23:05:30]

luoe@chromium.org changed reviewers:
+ allada@chromium.org, lushnikov@chromium.org

[luoe, 2017-04-18 23:05:30]

Please take a look

[allada, 2017-04-18 23:25:43]

lgtm

https://codereview.chromium.org/2823233004/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/inspector/sources/pretty-print-javascript-9.html
(right):

https://codereview.chromium.org/2823233004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector/sources/pretty-print-javascript-9.html:4:
<script src="../../http/tests/inspector/debugger-test.js"></script>
I don't think we need debugger-test.js, can you please confirm it's needed?

[luoe, 2017-04-18 23:33:55]

https://codereview.chromium.org/2823233004/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/inspector/sources/pretty-print-javascript-9.html
(right):

https://codereview.chromium.org/2823233004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector/sources/pretty-print-javascript-9.html:4:
<script src="../../http/tests/inspector/debugger-test.js"></script>
On 2017/04/18 23:25:42, allada wrote:
> I don't think we need debugger-test.js, can you please confirm it's needed?

Looks like we don't!  All the other 'pretty-print-javascript-N.html' tests seem
to have it as well.

We can do this for the other tests as well.  I think a future CL that does it
along with moving them to inspector-unit would be more appropriate.

[lushnikov, 2017-04-19 19:45:55]

lgtm

[luoe, 2017-04-19 19:49:16]

The CQ bit was checked by luoe@chromium.org

[luoe, 2017-04-19 19:49:17]

The patchset sent to the CQ was uploaded after l-g-t-m from allada@chromium.org
Link to the patchset: https://codereview.chromium.org/2823233004/#ps20001
(title: "ac")

[commit-bot: I haz the power, 2017-04-19 19:50:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 21:16:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 21:16:32]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[luoe, 2017-04-20 02:22:51]

The CQ bit was checked by luoe@chromium.org

[commit-bot: I haz the power, 2017-04-20 02:23:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 02:59:23]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492654971528020,
"parent_rev": "9b5142bcd05555d4c293464984cd34a33ad4af44", "commit_rev":
"079dd5c40c3a59e588777c794a533f40755f8402"}

[commit-bot: I haz the power, 2017-04-20 02:59:30]

Description was changed from

==========
DevTools: make JSFormatter aware of parenthesized expressions

JavascriptFormatter calls _beforeVisit() to collect tokens before visiting AST
nodes. However, the Acorn-provided AST did not generate enough info to
distinguish when the last ')' appeared, and our formatter would incorrectly add
a new line and indent whenever it saw any ')'.

This resulted in bad cases with expressions within more than one set of
parentheses (`if ((c))a;else b`).

This CL turns on an Acorn flag 'preserveParens' in order to distinguish and
insert a new line only for ')'s outside of a parenthesized expression.

Other examples:
with((c))a;
for (i=0; i< 5; (i++)){a;}
while ((true))x;

BUG=708493
==========

to

==========
DevTools: make JSFormatter aware of parenthesized expressions

JavascriptFormatter calls _beforeVisit() to collect tokens before visiting AST
nodes. However, the Acorn-provided AST did not generate enough info to
distinguish when the last ')' appeared, and our formatter would incorrectly add
a new line and indent whenever it saw any ')'.

This resulted in bad cases with expressions within more than one set of
parentheses (`if ((c))a;else b`).

This CL turns on an Acorn flag 'preserveParens' in order to distinguish and
insert a new line only for ')'s outside of a parenthesized expression.

Other examples:
with((c))a;
for (i=0; i< 5; (i++)){a;}
while ((true))x;

BUG=708493

Review-Url: https://codereview.chromium.org/2823233004
Cr-Commit-Position: refs/heads/master@{#465874}
Committed:
https://chromium.googlesource.com/chromium/src/+/079dd5c40c3a59e588777c794a53...
==========

[commit-bot: I haz the power, 2017-04-20 02:59:31]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/079dd5c40c3a59e588777c794a53...