Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 2823203003: Replace ASSERT_NOT_REACHED with NOTREACHED in modules/fetch (Closed)

Created:
3 years, 8 months ago by pilgrim_google
Modified:
3 years, 8 months ago
Reviewers:
tkent, haraken
CC:
blink-reviews, chromium-reviews, jsbell
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace ASSERT_NOT_REACHED with NOTREACHED in modules/fetch BUG=707652 Review-Url: https://codereview.chromium.org/2823203003 Cr-Commit-Position: refs/heads/master@{#465358} Committed: https://chromium.googlesource.com/chromium/src/+/a5aeed2fbccf03aaaaea0df38fc0ea08ca0f5fbb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchManager.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/Request.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/Response.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
pilgrim_google
3 years, 8 months ago (2017-04-18 15:58:37 UTC) #2
haraken
LGTM BTW you have completed the renaming of WTF container methods, right?
3 years, 8 months ago (2017-04-18 16:00:52 UTC) #3
pilgrim_google
On 2017/04/18 at 16:00:52, haraken wrote: > BTW you have completed the renaming of WTF ...
3 years, 8 months ago (2017-04-18 16:25:40 UTC) #6
haraken
On 2017/04/18 16:25:40, pilgrim_google wrote: > On 2017/04/18 at 16:00:52, haraken wrote: > > BTW ...
3 years, 8 months ago (2017-04-18 16:27:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2823203003/1
3 years, 8 months ago (2017-04-18 20:42:01 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 20:47:48 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a5aeed2fbccf03aaaaea0df38fc0...

Powered by Google App Engine
This is Rietveld 408576698