Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2823203002: [turbofan] Avoid -0 checks for truncating word32 uses. (Closed)

Created:
3 years, 8 months ago by Benedikt Meurer
Modified:
3 years, 8 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Avoid -0 checks for truncating word32 uses. The CheckBounds operator identifies zeros, but we ignore these bits in the representation selector, which generates unnecessary -0 checks for array accesses. R=jarin@chromium.org BUG=v8:5267 Review-Url: https://codereview.chromium.org/2823203002 Cr-Commit-Position: refs/heads/master@{#44680} Committed: https://chromium.googlesource.com/v8/v8/+/bd72be6f43e010e59c28c71f2d571c63cf9282a3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M src/compiler/representation-change.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/representation-change.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Benedikt Meurer
3 years, 8 months ago (2017-04-18 11:23:09 UTC) #1
Jarin
lgtm
3 years, 8 months ago (2017-04-18 11:24:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2823203002/1
3 years, 8 months ago (2017-04-18 11:27:12 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 11:48:10 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/bd72be6f43e010e59c28c71f2d571c63cf9...

Powered by Google App Engine
This is Rietveld 408576698