Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2823143002:
[MD settings] align sliders with margin (Closed)
|
Created:
3 years, 8 months ago by dschuyler Modified:
3 years, 8 months ago Reviewers:
stevenjb CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Description[MD settings] align sliders with margin
This CL moves the slider controls toward the end of the line so that
they visually align with the right-hand margin.
BUG=710916
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2823143002
Cr-Commit-Position: refs/heads/master@{#465369}
Committed: https://chromium.googlesource.com/chromium/src/+/17b99ff033da165b9cb52dc6d611e1da28b07b81
Patch Set 1 #
Total comments: 2
Patch Set 2 : nits #Messages
Total messages: 20 (15 generated)
Description was changed from ========== [MD settings] align sliders with margin This CL moves the slider controls toward the end of the line so that they visually align with the right-hand margin. BUG=710916 ========== to ========== [MD settings] align sliders with margin This CL moves the slider controls toward the end of the line so that they visually align with the right-hand margin. BUG=710916 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
dschuyler@chromium.org changed reviewers: + stevenjb@chromium.org
dschuyler@chromium.org changed reviewers: + stevenjb@chromium.org
https://codereview.chromium.org/2823143002/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/controls/settings_slider.html (right): https://codereview.chromium.org/2823143002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/controls/settings_slider.html:13: calc(-15px - var(--calculated-paper-slider-height)/2); Lines 10 through 13 can be replaced with: -webkit-margin-end: -16px; /* Overlap margin. */ If that is preferred. It's less precise, but it's much easier to read.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm https://codereview.chromium.org/2823143002/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/controls/settings_slider.html (right): https://codereview.chromium.org/2823143002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/controls/settings_slider.html:13: calc(-15px - var(--calculated-paper-slider-height)/2); On 2017/04/18 00:55:24, dschuyler wrote: > Lines 10 through 13 can be replaced with: > > -webkit-margin-end: -16px; /* Overlap margin. */ > > If that is preferred. It's less precise, but it's much easier to read. This seems fine to me. nit: space surrounding '/'
The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by dschuyler@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from stevenjb@chromium.org Link to the patchset: https://codereview.chromium.org/2823143002/#ps20001 (title: "nits")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492548799945550,
"parent_rev": "e4a5dd4fe77a84d1da83efb0e99b217da512a50e", "commit_rev":
"17b99ff033da165b9cb52dc6d611e1da28b07b81"}
Message was sent while issue was closed.
Description was changed from ========== [MD settings] align sliders with margin This CL moves the slider controls toward the end of the line so that they visually align with the right-hand margin. BUG=710916 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [MD settings] align sliders with margin This CL moves the slider controls toward the end of the line so that they visually align with the right-hand margin. BUG=710916 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2823143002 Cr-Commit-Position: refs/heads/master@{#465369} Committed: https://chromium.googlesource.com/chromium/src/+/17b99ff033da165b9cb52dc6d611... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/17b99ff033da165b9cb52dc6d611... |
