auth: Remove 'secrets' from replication.proto.

auth: Remove 'secrets' from replication.proto.

This is first CL in a series of CLs that remove the notion of "global secrets".
We never used them, they just unnecessary confuse and frighten people.

R=iannucci@chromium.org
BUG=712507
Review-Url: https://codereview.chromium.org/2823113003
Committed: https://github.com/luci/luci-py/commit/def5fc8357e1334184e34d08750c8a8ab17d3141

[Vadim Sh., 2017-04-18 01:15:31]

PTAL. Just code removal.

[iannucci, 2017-04-18 02:41:24]

lgtm

https://codereview.chromium.org/2823113003/diff/1/appengine/components/compon...
File appengine/components/components/auth/proto/replication.proto (right):

https://codereview.chromium.org/2823113003/diff/1/appengine/components/compon...
appengine/components/components/auth/proto/replication.proto:154: reserved 5;
maybe comment of what this used to be?

[Vadim Sh., 2017-04-18 03:31:45]

Description was changed from

==========
auth: Remove 'secrets' from replication.proto.

This is first CL in a series of CLs that remove the notion of "global secrets".
We never used them, they just unnecessary confuse and frighten people.

R=iannucci@chromium.org
BUG=
==========

to

==========
auth: Remove 'secrets' from replication.proto.

This is first CL in a series of CLs that remove the notion of "global secrets".
We never used them, they just unnecessary confuse and frighten people.

R=iannucci@chromium.org
BUG=712507
==========

[Vadim Sh., 2017-04-18 03:32:30]

https://codereview.chromium.org/2823113003/diff/1/appengine/components/compon...
File appengine/components/components/auth/proto/replication.proto (right):

https://codereview.chromium.org/2823113003/diff/1/appengine/components/compon...
appengine/components/components/auth/proto/replication.proto:154: reserved 5;
On 2017/04/18 02:41:24, iannucci wrote:
> maybe comment of what this used to be?

Done.

[Vadim Sh., 2017-04-18 03:32:34]

The CQ bit was checked by vadimsh@chromium.org

[Vadim Sh., 2017-04-18 03:32:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
iannucci@chromium.org
Link to the patchset: https://codereview.chromium.org/2823113003/#ps20001
(title: "comment reserved")

[commit-bot: I haz the power, 2017-04-18 03:32:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 03:35:12]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492486354878720,
"parent_rev": "c275932b28689141f33375febaddd9f10f164cfd", "commit_rev":
"def5fc8357e1334184e34d08750c8a8ab17d3141"}

[commit-bot: I haz the power, 2017-04-18 03:35:19]

Description was changed from

==========
auth: Remove 'secrets' from replication.proto.

This is first CL in a series of CLs that remove the notion of "global secrets".
We never used them, they just unnecessary confuse and frighten people.

R=iannucci@chromium.org
BUG=712507
==========

to

==========
auth: Remove 'secrets' from replication.proto.

This is first CL in a series of CLs that remove the notion of "global secrets".
We never used them, they just unnecessary confuse and frighten people.

R=iannucci@chromium.org
BUG=712507

Review-Url: https://codereview.chromium.org/2823113003
Committed:
https://github.com/luci/luci-py/commit/def5fc8357e1334184e34d08750c8a8ab17d3141
==========

[commit-bot: I haz the power, 2017-04-18 03:35:20]

Committed patchset #2 (id:20001) as
https://github.com/luci/luci-py/commit/def5fc8357e1334184e34d08750c8a8ab17d3141