Fix crash in PaintOpBuffer alpha optimization

Fix crash in PaintOpBuffer alpha optimization

PaintOpBuffer in general checks if ops are draw ops before applying
the save/draw/restore alpha folding optimization to remove save layers.
However, the specific code that tries to recursively apply this op
to DrawRecordOp with a single op does not check draw op status.

Printing generates single op pictures containing annotate ops (for pdf
links, etc), which causes this to crash in practice.

The last unit test in this patch causes this to crash without the code
change applied.  The other unit tests are there just for completeness.

An alternative to this patch would be to implement RasterWithAlpha for
all op types, but that seems like needless code gen for a bunch of
functions that will never get called in practice.

BUG=712093
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2823113002
Cr-Commit-Position: refs/heads/master@{#465145}
Committed: https://chromium.googlesource.com/chromium/src/+/52c5ec950ba33ce26507840a34fd8690f86fe801

[enne (OOO), 2017-04-17 23:33:15]

Description was changed from

==========
Fix crash in PaintOpBuffer alpha optimization

PaintOpBuffer in general checks if ops are draw ops before applying
the save/draw/restore alpha folding optimization to remove save layers.
However, the specific code that tries to recursively apply this op
to DrawRecordOp with a single op does not check draw op status.

Printing generates single op pictures containing annotate ops (for pdf
links, etc), which causes this to crash in practice.

The last unit test in this patch causes this to crash without the code
change applied.  The other unit tests are there just for completeness.

An alternative to this patch would be to implement RasterWithAlpha for
all op types, but that seems like needless code gen for a bunch of
functions that will never get called in practice.

BUG=712093
==========

to

==========
Fix crash in PaintOpBuffer alpha optimization

PaintOpBuffer in general checks if ops are draw ops before applying
the save/draw/restore alpha folding optimization to remove save layers.
However, the specific code that tries to recursively apply this op
to DrawRecordOp with a single op does not check draw op status.

Printing generates single op pictures containing annotate ops (for pdf
links, etc), which causes this to crash in practice.

The last unit test in this patch causes this to crash without the code
change applied.  The other unit tests are there just for completeness.

An alternative to this patch would be to implement RasterWithAlpha for
all op types, but that seems like needless code gen for a bunch of
functions that will never get called in practice.

BUG=712093
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[enne (OOO), 2017-04-17 23:33:29]

enne@chromium.org changed reviewers:
+ vmpstr@chromium.org

[enne (OOO), 2017-04-17 23:33:38]

The CQ bit was checked by enne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-17 23:34:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vmpstr, 2017-04-17 23:39:00]

lgtm

[commit-bot: I haz the power, 2017-04-18 00:28:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 00:28:12]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[enne (OOO), 2017-04-18 03:53:51]

The CQ bit was checked by enne@chromium.org

[enne (OOO), 2017-04-18 03:53:52]

The patchset sent to the CQ was uploaded after l-g-t-m from vmpstr@chromium.org
Link to the patchset: https://codereview.chromium.org/2823113002/#ps20001
(title: "Fix windows question mark")

[commit-bot: I haz the power, 2017-04-18 03:54:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 05:07:07]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492487631555260,
"parent_rev": "e4904c3670d6a8d4f88642ca7e18ca2a9878a684", "commit_rev":
"52c5ec950ba33ce26507840a34fd8690f86fe801"}

[commit-bot: I haz the power, 2017-04-18 05:07:58]

Description was changed from

==========
Fix crash in PaintOpBuffer alpha optimization

PaintOpBuffer in general checks if ops are draw ops before applying
the save/draw/restore alpha folding optimization to remove save layers.
However, the specific code that tries to recursively apply this op
to DrawRecordOp with a single op does not check draw op status.

Printing generates single op pictures containing annotate ops (for pdf
links, etc), which causes this to crash in practice.

The last unit test in this patch causes this to crash without the code
change applied.  The other unit tests are there just for completeness.

An alternative to this patch would be to implement RasterWithAlpha for
all op types, but that seems like needless code gen for a bunch of
functions that will never get called in practice.

BUG=712093
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Fix crash in PaintOpBuffer alpha optimization

PaintOpBuffer in general checks if ops are draw ops before applying
the save/draw/restore alpha folding optimization to remove save layers.
However, the specific code that tries to recursively apply this op
to DrawRecordOp with a single op does not check draw op status.

Printing generates single op pictures containing annotate ops (for pdf
links, etc), which causes this to crash in practice.

The last unit test in this patch causes this to crash without the code
change applied.  The other unit tests are there just for completeness.

An alternative to this patch would be to implement RasterWithAlpha for
all op types, but that seems like needless code gen for a bunch of
functions that will never get called in practice.

BUG=712093
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2823113002
Cr-Commit-Position: refs/heads/master@{#465145}
Committed:
https://chromium.googlesource.com/chromium/src/+/52c5ec950ba33ce26507840a34fd...
==========

[commit-bot: I haz the power, 2017-04-18 05:07:59]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/52c5ec950ba33ce26507840a34fd...