Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1360)

Issue 2823063002: Consolidate canvas color params into a single class (Closed)

Created:
3 years, 8 months ago by ccameron
Modified:
3 years, 8 months ago
CC:
chromium-reviews, krit, dshwang, drott+blinkwatch_chromium.org, ajuma+watch-canvas_chromium.org, blink-reviews-html_chromium.org, pdr+graphicswatchlist_chromium.org, Justin Novosad, blink-reviews-platform-graphics_chromium.org, dglazkov+blink, Rik, fmalita+watch_chromium.org, blink-reviews, kinuko+watch, ajuma+watch_chromium.org, Stephen Chennney, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Consolidate canvas color params into a single class This data is propagated to many of the classes for allocating surfaces. Put it in a single place for convenience. BUG=711107 Review-Url: https://codereview.chromium.org/2823063002 Cr-Commit-Position: refs/heads/master@{#465087} Committed: https://chromium.googlesource.com/chromium/src/+/60c4a2e6afafac1ddacf83ca4c4fd75d6ee1bc15

Patch Set 1 #

Patch Set 2 : Fix compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -55 lines) Patch
M third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h View 4 chunks +5 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.cpp View 5 chunks +24 lines, -35 lines 0 comments Download
M third_party/WebKit/Source/platform/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/graphics/CanvasColorParams.h View 1 chunk +59 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/graphics/CanvasColorParams.cpp View 1 1 chunk +49 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
ccameron
This consolidates the functions, but doesn't propagate into the classes that get this data -- ...
3 years, 8 months ago (2017-04-17 21:18:01 UTC) #5
zakerinasab
On 2017/04/17 21:18:01, ccameron wrote: > This consolidates the functions, but doesn't propagate into the ...
3 years, 8 months ago (2017-04-17 21:22:49 UTC) #6
ccameron
Adding pdr@ to OWNERs (junov is OOO)
3 years, 8 months ago (2017-04-17 23:08:34 UTC) #9
pdr.
On 2017/04/17 at 23:08:34, ccameron wrote: > Adding pdr@ to OWNERs (junov is OOO) LGTM
3 years, 8 months ago (2017-04-17 23:10:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2823063002/20001
3 years, 8 months ago (2017-04-17 23:12:20 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 01:04:13 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/60c4a2e6afafac1ddacf83ca4c4f...

Powered by Google App Engine
This is Rietveld 408576698