Do not silently drop \u0000 in base::JSONReader

Do not silently drop \u0000 in base::JSONReader

When encoding a string containing nul bytes base::JSONWriter will emit
the Unicode escape sequence "\u0000" which is valid JSON.
base::JSONReader however supports the nonstandard "\x00" escape sequence
but will silently drop the character "\u0000". This patch fixes
JSONParser::DecodeUTF16() properly append nul bytes to the output
string.

BUG=268991
Review-Url: https://codereview.chromium.org/2823023002
Cr-Commit-Position: refs/heads/master@{#465018}
Committed: https://chromium.googlesource.com/chromium/src/+/686319f537227990eb77e717897691bcb7171187

[Reilly Grant (use Gerrit), 2017-04-17 19:13:29]

The CQ bit was checked by reillyg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-17 19:13:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-17 20:31:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-17 20:31:45]

Dry run: This issue passed the CQ dry run.

[Reilly Grant (use Gerrit), 2017-04-17 20:37:27]

reillyg@chromium.org changed reviewers:
+ mark@chromium.org

[Reilly Grant (use Gerrit), 2017-04-17 20:37:27]

PTAL

[Mark Mentovai, 2017-04-17 21:06:49]

mark@chromium.org changed reviewers:
+ rsesek@chromium.org

[Mark Mentovai, 2017-04-17 21:06:50]

LGTM, but +rsesek too. He wrote this parser, if this handling of \u0000 was
intentional, he’d know.

[Robert Sesek, 2017-04-17 21:09:33]

LGTM

[Reilly Grant (use Gerrit), 2017-04-17 21:10:11]

Thanks. There is also likely some optimization to be done because DecodeUTF16
builds a temporary string while DecodeUTF8 appends directly to the StringBuilder
but I wanted to keep this change simple to avoid introducing other subtle
issues.

[Reilly Grant (use Gerrit), 2017-04-17 21:10:18]

The CQ bit was checked by reillyg@chromium.org

[commit-bot: I haz the power, 2017-04-17 21:10:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-17 21:14:05]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492463418284380, "parent_rev":
"4f41087cb29ed77a0840c22cee5b5c30011b8112", "commit_rev":
"686319f537227990eb77e717897691bcb7171187"}

[commit-bot: I haz the power, 2017-04-17 21:14:13]

Description was changed from

==========
Do not silently drop \u0000 in base::JSONReader

When encoding a string containing nul bytes base::JSONWriter will emit
the Unicode escape sequence "\u0000" which is valid JSON.
base::JSONReader however supports the nonstandard "\x00" escape sequence
but will silently drop the character "\u0000". This patch fixes
JSONParser::DecodeUTF16() properly append nul bytes to the output
string.

BUG=268991
==========

to

==========
Do not silently drop \u0000 in base::JSONReader

When encoding a string containing nul bytes base::JSONWriter will emit
the Unicode escape sequence "\u0000" which is valid JSON.
base::JSONReader however supports the nonstandard "\x00" escape sequence
but will silently drop the character "\u0000". This patch fixes
JSONParser::DecodeUTF16() properly append nul bytes to the output
string.

BUG=268991

Review-Url: https://codereview.chromium.org/2823023002
Cr-Commit-Position: refs/heads/master@{#465018}
Committed:
https://chromium.googlesource.com/chromium/src/+/686319f537227990eb77e7178976...
==========

[commit-bot: I haz the power, 2017-04-17 21:14:14]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/686319f537227990eb77e7178976...