content/shell/test_runner/pixel_dump.cc - Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/test_runner/pixel_dump.cc

Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock (Closed)

Patch Set: fix mac Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/shell/test_runner/pixel_dump.cc

diff --git a/content/shell/test_runner/pixel_dump.cc b/content/shell/test_runner/pixel_dump.cc

index 6252a44da9555287b2b8891998fe327d2428e04b..123030fed6bc974b2c6f953d71e4a560010601f9 100644

--- a/content/shell/test_runner/pixel_dump.cc

+++ b/content/shell/test_runner/pixel_dump.cc

@@ -204,9 +204,7 @@ void CopyImageAtAndCapturePixels(

blink::WebImage image = static_cast<blink::WebMockClipboard*>(

blink::Platform::Current()->Clipboard())

->ReadRawImage(blink::WebClipboard::Buffer());

- const SkBitmap& bitmap = image.GetSkBitmap();

- SkAutoLockPixels autoLock(bitmap);

- callback.Run(bitmap);

+ callback.Run(image.GetSkBitmap());

}

} // namespace test_runner