content/shell/renderer/layout_test/blink_test_runner.cc - Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/renderer/layout_test/blink_test_runner.cc

Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock (Closed)

Patch Set: fix mac Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/shell/renderer/layout_test/blink_test_runner.cc

diff --git a/content/shell/renderer/layout_test/blink_test_runner.cc b/content/shell/renderer/layout_test/blink_test_runner.cc

index 24b8b7083f25c40f862c7146a028e2a6dd00a242..9dc64e31ec2301bae61f3fb6be1e667622172cb9 100644

--- a/content/shell/renderer/layout_test/blink_test_runner.cc

+++ b/content/shell/renderer/layout_test/blink_test_runner.cc

@@ -937,7 +937,6 @@ void BlinkTestRunner::OnPixelsDumpCompleted(const SkBitmap& snapshot) {

DCHECK_NE(0, snapshot.info().width());

DCHECK_NE(0, snapshot.info().height());

- SkAutoLockPixels snapshot_lock(snapshot);

// The snapshot arrives from the GPU process via shared memory. Because MSan

// can't track initializedness across processes, we must assure it that the

// pixels are in fact initialized.