chrome/browser/ui/exclusive_access/flash_fullscreen_interactive_browsertest.cc - Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/exclusive_access/flash_fullscreen_interactive_browsertest.cc

Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock (Closed)

Patch Set: fix mac Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« cc/resources/ui_resource_bitmap.h ('K') | « chrome/browser/thumbnails/content_analysis_unittest.cc ('k') | chrome/browser/ui/libgtkui/skia_utils_gtk.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/exclusive_access/flash_fullscreen_interactive_browsertest.cc

diff --git a/chrome/browser/ui/exclusive_access/flash_fullscreen_interactive_browsertest.cc b/chrome/browser/ui/exclusive_access/flash_fullscreen_interactive_browsertest.cc

index 05cc335a3cf0aa87c75d160a49bd2c72fbca8b2e..b26cf9f13db9bf7e20cc5699130b1d6a1f3eabd9 100644

--- a/chrome/browser/ui/exclusive_access/flash_fullscreen_interactive_browsertest.cc

+++ b/chrome/browser/ui/exclusive_access/flash_fullscreen_interactive_browsertest.cc

@@ -282,7 +282,6 @@ class FlashFullscreenInteractiveBrowserTest : public OutOfProcessPPAPITest {

const SkBitmap& bitmap,

content::ReadbackResponse response) {

if (response == content::READBACK_SUCCESS) {

- SkAutoLockPixels lock_pixels(bitmap);

if (bitmap.width() > 0 && bitmap.height() > 0)

*is_expected_color = (bitmap.getColor(0, 0) == expected_color);

}

« cc/resources/ui_resource_bitmap.h ('K') | « chrome/browser/thumbnails/content_analysis_unittest.cc ('k') | chrome/browser/ui/libgtkui/skia_utils_gtk.cc » ('j') | no next file with comments »