chrome/browser/thumbnails/content_analysis_unittest.cc - Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/thumbnails/content_analysis_unittest.cc

Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock (Closed)

Patch Set: fix mac Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/thumbnails/content_analysis_unittest.cc

diff --git a/chrome/browser/thumbnails/content_analysis_unittest.cc b/chrome/browser/thumbnails/content_analysis_unittest.cc

index 547c51a45a7516e5cff9bd73e6c476592bcb8b20..387da01ec4fec0dcefa5f5ff84c5dfbba5425693 100644

--- a/chrome/browser/thumbnails/content_analysis_unittest.cc

+++ b/chrome/browser/thumbnails/content_analysis_unittest.cc

@@ -54,8 +54,6 @@ bool CompareImageFragments(const SkBitmap& bitmap_left,

const gfx::Size& comparison_area,

const gfx::Point& origin_left,

const gfx::Point& origin_right) {

- SkAutoLockPixels left_lock(bitmap_left);

- SkAutoLockPixels right_lock(bitmap_right);

for (int r = 0; r < comparison_area.height(); ++r) {

for (int c = 0; c < comparison_area.width(); ++c) {

SkColor color_left = bitmap_left.getColor(origin_left.x() + c,