Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(876)

Unified Diff: ui/gfx/image/image_util.cc

Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock (Closed)
Patch Set: win fix after rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/gfx/image/image_unittest_util.cc ('k') | ui/gfx/ipc/skia/OWNERS » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/image/image_util.cc
diff --git a/ui/gfx/image/image_util.cc b/ui/gfx/image/image_util.cc
index 3fca705a8256bf341070991f748e3805b53f1c80..16387149d142c76d4d91126c314a526b8c3c8249 100644
--- a/ui/gfx/image/image_util.cc
+++ b/ui/gfx/image/image_util.cc
@@ -62,8 +62,6 @@ bool JPEG1xEncodedDataFromSkiaRepresentation(const Image& image,
return false;
const SkBitmap& bitmap = image_skia_rep.sk_bitmap();
- SkAutoLockPixels bitmap_lock(bitmap);
-
if (!bitmap.readyToDraw())
return false;
@@ -85,7 +83,6 @@ void GetVisibleMargins(const ImageSkia& image, int* left, int* right) {
if (bitmap.drawsNothing() || bitmap.isOpaque())
return;
- SkAutoLockPixels lock(bitmap);
int x = 0;
for (; x < bitmap.width(); ++x) {
if (ColumnHasVisiblePixels(bitmap, x)) {
« no previous file with comments | « ui/gfx/image/image_unittest_util.cc ('k') | ui/gfx/ipc/skia/OWNERS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698