ui/gfx/color_utils.cc - Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gfx/color_utils.cc

Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock (Closed)

Patch Set: win fix after rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/gfx/color_utils.cc

diff --git a/ui/gfx/color_utils.cc b/ui/gfx/color_utils.cc

index 95dea0936c0fc4d35494ef7ed8e450b7873c013f..257990d9680eafee515799cb18999e4887e422e2 100644

--- a/ui/gfx/color_utils.cc

+++ b/ui/gfx/color_utils.cc

@@ -236,8 +236,6 @@ SkColor HSLShift(SkColor color, const HSL& shift) {

void BuildLumaHistogram(const SkBitmap& bitmap, int histogram[256]) {

DCHECK_EQ(kN32_SkColorType, bitmap.colorType());

- SkAutoLockPixels bitmap_lock(bitmap);

int pixel_width = bitmap.width();

int pixel_height = bitmap.height();

for (int y = 0; y < pixel_height; ++y) {

« no previous file with comments | « ui/gfx/color_analysis_unittest.cc ('k') | ui/gfx/icon_util.cc » ('j') | no next file with comments »