Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Unified Diff: ui/gfx/color_analysis_unittest.cc

Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock (Closed)
Patch Set: win fix after rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/gfx/color_analysis.cc ('k') | ui/gfx/color_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/color_analysis_unittest.cc
diff --git a/ui/gfx/color_analysis_unittest.cc b/ui/gfx/color_analysis_unittest.cc
index 32444dbc9fe9afbc31b04f1a4dc16c22c487e3d2..93fc2db63bc4bccc3ae67a12db9c93aa26ae8a02 100644
--- a/ui/gfx/color_analysis_unittest.cc
+++ b/ui/gfx/color_analysis_unittest.cc
@@ -99,7 +99,6 @@ scoped_refptr<base::RefCountedMemory> CreateTestPNG(
SkBitmap bitmap;
bitmap.allocN32Pixels(colors.size(), 1);
- SkAutoLockPixels lock(bitmap);
for (size_t i = 0; i < colors.size(); ++i) {
bitmap.eraseArea(SkIRect::MakeXYWH(i, 0, 1, 1), colors[i]);
}
@@ -149,7 +148,6 @@ bool ChannelApproximatelyEqual(int expected, uint8_t channel) {
void Calculate8bitBitmapMinMax(const SkBitmap& bitmap,
uint8_t* min_gl,
uint8_t* max_gl) {
- SkAutoLockPixels bitmap_lock(bitmap);
DCHECK(bitmap.getPixels());
DCHECK_EQ(bitmap.colorType(), kAlpha_8_SkColorType);
DCHECK(min_gl);
« no previous file with comments | « ui/gfx/color_analysis.cc ('k') | ui/gfx/color_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698