Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Unified Diff: ui/gfx/codec/png_codec.h

Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock (Closed)
Patch Set: win fix after rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/gfx/canvas.cc ('k') | ui/gfx/codec/png_codec.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/codec/png_codec.h
diff --git a/ui/gfx/codec/png_codec.h b/ui/gfx/codec/png_codec.h
index bcc30e758e6e91e1e249571d14a006884bbbf2f6..0ae9a81d33cbfe5b63c182a27cccc6f481d5e9ed 100644
--- a/ui/gfx/codec/png_codec.h
+++ b/ui/gfx/codec/png_codec.h
@@ -83,8 +83,7 @@ class CODEC_EXPORT PNGCodec {
// Call PNGCodec::Encode on the supplied SkBitmap |input|, which is assumed
// to be kARGB_8888_Config, 32 bits per pixel. The params
// |discard_transparency| and |output| are passed directly to Encode; refer to
- // Encode for more information. During the call, an SkAutoLockPixels lock
- // is held on |input|.
+ // Encode for more information.
static bool EncodeBGRASkBitmap(const SkBitmap& input,
bool discard_transparency,
std::vector<unsigned char>* output);
@@ -99,8 +98,7 @@ class CODEC_EXPORT PNGCodec {
// Call PNGCodec::Encode on the supplied SkBitmap |input|, which is assumed
// to be kA8_Config, 8 bits per pixel. The bitmap is encoded as a grayscale
// PNG with alpha used for color intensity. The |output| param is passed
- // directly to Encode; refer to Encode for more information. During the call,
- // an SkAutoLockPixels lock is held on |input|.
+ // directly to Encode; refer to Encode for more information.
static bool EncodeA8SkBitmap(const SkBitmap& input,
std::vector<unsigned char>* output);
« no previous file with comments | « ui/gfx/canvas.cc ('k') | ui/gfx/codec/png_codec.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698