ui/gfx/codec/png_codec.cc - Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gfx/codec/png_codec.cc

Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock (Closed)

Patch Set: win fix after rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/gfx/codec/png_codec.cc

diff --git a/ui/gfx/codec/png_codec.cc b/ui/gfx/codec/png_codec.cc

index 7f0a569d7892e09eac7219d2449a5e85ac7ec52d..69a00c19449403b6a3853627217af1e18b838cfc 100644

--- a/ui/gfx/codec/png_codec.cc

+++ b/ui/gfx/codec/png_codec.cc

@@ -731,7 +731,6 @@ bool InternalEncodeSkBitmap(const SkBitmap& input,

int bpp = input.bytesPerPixel();

DCHECK(bpp == 1 || bpp == 4); // We support kA8_Config and kARGB_8888_Config.

- SkAutoLockPixels lock_input(input);

unsigned char* inputAddr = bpp == 1 ?

reinterpret_cast<unsigned char*>(input.getAddr8(0, 0)) :

reinterpret_cast<unsigned char*>(input.getAddr32(0, 0)); // bpp = 4

« no previous file with comments | « ui/gfx/codec/png_codec.h ('k') | ui/gfx/color_analysis.cc » ('j') | no next file with comments »