components/user_manager/user_image/user_image.cc - Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/user_manager/user_image/user_image.cc

Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock (Closed)

Patch Set: win fix after rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/user_manager/user_image/user_image.cc

diff --git a/components/user_manager/user_image/user_image.cc b/components/user_manager/user_image/user_image.cc

index 23c763ff7334af53e18f996c5554335b64efb5a2..db293d53b30249a1bfa9cc8849b64a78e63933eb 100644

--- a/components/user_manager/user_image/user_image.cc

+++ b/components/user_manager/user_image/user_image.cc

@@ -26,7 +26,6 @@ scoped_refptr<base::RefCountedBytes> UserImage::Encode(

ImageFormat image_format) {

TRACE_EVENT2("oobe", "UserImage::Encode",

"width", bitmap.width(), "height", bitmap.height());

- SkAutoLockPixels lock_bitmap(bitmap);

std::vector<unsigned char> output;

auto* bitmap_data = reinterpret_cast<unsigned char*>(bitmap.getAddr32(0, 0));

if (image_format == FORMAT_JPEG) {