components/suggestions/image_encoder.cc - Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/suggestions/image_encoder.cc

Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock (Closed)

Patch Set: win fix after rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/suggestions/image_encoder.cc

diff --git a/components/suggestions/image_encoder.cc b/components/suggestions/image_encoder.cc

index 73283cf5bbbd694cdc5e8eacc9060841f87cc129..8b0fa09fc260d64b8df3bc12cf5499dd017f604e 100644

--- a/components/suggestions/image_encoder.cc

+++ b/components/suggestions/image_encoder.cc

@@ -17,7 +17,6 @@ std::unique_ptr<SkBitmap> DecodeJPEGToSkBitmap(const void* encoded_data,

bool EncodeSkBitmapToJPEG(const SkBitmap& bitmap,

std::vector<unsigned char>* dest) {

- SkAutoLockPixels bitmap_lock(bitmap);

if (!bitmap.readyToDraw() || bitmap.isNull()) {

return false;

}