chrome/browser/chromeos/login/users/avatar/user_image_manager_test_util.cc - Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/users/avatar/user_image_manager_test_util.cc

Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock (Closed)

Patch Set: win fix after rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/screenshot_testing/SkPMetric.cpp ('k') | chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_policy_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/users/avatar/user_image_manager_test_util.cc

diff --git a/chrome/browser/chromeos/login/users/avatar/user_image_manager_test_util.cc b/chrome/browser/chromeos/login/users/avatar/user_image_manager_test_util.cc

index 33e8b476bbdc7bd027848b4fe2ed69be58efba62..1875e95544b85a7ad89d1c798f7c7df5ff7e62d2 100644

--- a/chrome/browser/chromeos/login/users/avatar/user_image_manager_test_util.cc

+++ b/chrome/browser/chromeos/login/users/avatar/user_image_manager_test_util.cc

@@ -37,8 +37,6 @@ bool AreImagesEqual(const gfx::ImageSkia& first, const gfx::ImageSkia& second) {

if (second_bitmap->getSize() != size)

return false;

- SkAutoLockPixels first_pixel_lock(*first_bitmap);

- SkAutoLockPixels second_pixel_lock(*second_bitmap);

uint8_t* first_data = reinterpret_cast<uint8_t*>(first_bitmap->getPixels());

uint8_t* second_data = reinterpret_cast<uint8_t*>(second_bitmap->getPixels());

for (size_t i = 0; i < size; ++i) {