Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6515)

Unified Diff: chrome/browser/chromeos/login/screenshot_testing/SkPMetric.cpp

Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock (Closed)
Patch Set: win fix after rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/screenshot_testing/SkPMetric.cpp
diff --git a/chrome/browser/chromeos/login/screenshot_testing/SkPMetric.cpp b/chrome/browser/chromeos/login/screenshot_testing/SkPMetric.cpp
index 0f71ad5d94416c7cdb47acbb4106fca78cf6f31a..c551c5044c68105fffd690cb43c61dd402289101 100644
--- a/chrome/browser/chromeos/login/screenshot_testing/SkPMetric.cpp
+++ b/chrome/browser/chromeos/login/screenshot_testing/SkPMetric.cpp
@@ -139,7 +139,6 @@ static bool bitmap_to_cielab(const SkBitmap* bitmap, ImageLAB* outImageLAB) {
DCHECK(outImageLAB->width == width);
DCHECK(outImageLAB->height == height);
- bitmap->lockPixels();
RGB rgb;
LAB lab;
for (int y = 0; y < height; y++) {
@@ -153,7 +152,6 @@ static bool bitmap_to_cielab(const SkBitmap* bitmap, ImageLAB* outImageLAB) {
outImageLAB->writePixel(x, y, lab);
}
}
- bitmap->unlockPixels();
return true;
}

Powered by Google App Engine
This is Rietveld 408576698